Clean up MozButton fragment markup
Categories
(Toolkit :: UI Widgets, task, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: dao, Assigned: hamzah18051, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file, 1 obsolete file)
+++ This bug was initially created as a clone of Bug #1557281 +++
Here:
... we can replace ></image>
, ></label>
, and ></dropmarker>
with just />
.
Hi,
I would like to take this bug as my first, to familiarize myself with the tools. Is it possible ?
Comment 2•5 years ago
|
||
(In reply to Léo Jaillet from comment #1)
I would like to take this bug as my first, to familiarize myself with the tools. Is it possible ?
Sure, the first step is to get a working local build of Firefox. For this bug, I would suggest using artifact builds. You can follow the instructions here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds
Once you've got a local build, you can make the changes described in comment 0, rebuild Firefox, and do a quick sanity check that everything seems to be working properly. After that, you can follow these instructions to put together a patch:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
At that point, Dão or I can help you run automated tests to ensure that nothing else was broken inadvertently.
Good luck, and feel free to comment here if you get stuck or have questions.
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Comment hidden (obsolete) |
Assignee | ||
Comment 8•5 years ago
|
||
I would like to take up the issue and solve it if no-one is currently working on it.
Reporter | ||
Comment 9•5 years ago
|
||
(In reply to Hamzah Akhtar from comment #8)
I would like to take up the issue and solve it if no-one is currently working on it.
Go ahead! Let me know if you have questions.
Assignee | ||
Comment 10•5 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #9)
(In reply to Hamzah Akhtar from comment #8)
I would like to take up the issue and solve it if no-one is currently working on it.
Go ahead! Let me know if you have questions.
In which directory can I find the file button.js
inside mozilla-central?
Reporter | ||
Comment 11•5 years ago
|
||
(In reply to Hamzah Akhtar from comment #10)
In which directory can I find the file
button.js
inside mozilla-central?
toolkit/content/widgets/button.js
Assignee | ||
Comment 12•5 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #11)
(In reply to Hamzah Akhtar from comment #10)
In which directory can I find the file
button.js
inside mozilla-central?toolkit/content/widgets/button.js
It is not there. I even checked in https://searchfox.org/mozilla-central/search?q=buttons.js&path=
Reporter | ||
Comment 13•5 years ago
|
||
(In reply to Hamzah Akhtar from comment #12)
(In reply to Dão Gottwald [::dao] from comment #11)
(In reply to Hamzah Akhtar from comment #10)
In which directory can I find the file
button.js
inside mozilla-central?toolkit/content/widgets/button.js
It is not there. I even checked in https://searchfox.org/mozilla-central/search?q=buttons.js&path=
It's button.js, not buttons.js.
https://searchfox.org/mozilla-central/source/toolkit/content/widgets/button.js
Assignee | ||
Comment 14•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Comment 15•5 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/258f831d5d23 Clean up MozButtonBase fragment markup r=dao
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Comment 16•5 years ago
|
||
This will be resolved automatically when your patch gets merged to mozilla-central.
Comment 17•5 years ago
|
||
bugherder |
Reporter | ||
Updated•5 years ago
|
Description
•