1557936 - CMSOutputProfile entry in about:support excessively long

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

Attachment: support.zip

I'm not too sure what this entry is for, but it takes what feels like 1000 press on page-down to skip over it.

it's around 1 million characters long.

Comment 1

[Miko Mynttinen]

This was added in bug 1556822. I guess some length limit is needed.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Wow, most profiles I've seen are only a few kB. I don't think I can truncate it and be guaranteed to get something useful, but I can reject it with a note in the about:support saying it was too long.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1557936 - Don't put oversized CMS profiles in about:support.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d4915f544ca
Don't put oversized CMS profiles in about:support. r=miko

Comment 5

[Arthur Iakab [arthur_iakab]]

Backed out changeset 5d4915f544ca (bug 1557936) for causing build bustages on gfxPlatform.cpp

Backout revision https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=250971432

Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=250971432&revision=5d4915f544caaca6f3b251c0aead1a5c2209e758

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=250971405&repo=mozilla-inbound

@Andrew can you please take a look?

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01beba5c66da
Backed out changeset 5d4915f544ca for causing build bustages on gfxPlatform.cpp

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Ugh, silly printf, builds fine but not all configurations:

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c00beb857203d9fa67c0904b9e75ce812b91725

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79e19fcebe12
Don't put oversized CMS profiles in about:support. r=miko

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/79e19fcebe12

Comment 10

[Underpass]

Sorry, is this actually fixed? In Firefox 70 mine is 4192 characters long.

Comment 11

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Underpass from comment #10)

Sorry, is this actually fixed? In Firefox 70 mine is 4192 characters long.

It cuts them off at 8k.