Closed Bug 1558084 Opened 6 years ago Closed 6 years ago

List tree observer broken

Categories

(Calendar :: Dialogs, defect)

Product:
Calendar
Component:
Dialogs
Version:
Lightning 68
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: public, Assigned: public)

References

(Regression)

Details

Attachments

(1 file)

fix against comm-beta
1022 bytes, patch
pmorris
: review+
Fallen
: approval-calendar-beta+
Details | Diff | Splinter Review

The calendar-list-tree component's observer is referencing a different 'this' than intended.

STR:
Thunderbird 68 (I tested on comm-beta), clean profile with Lightning

  1. Rename the default "Home" calendar

Expected:
No errors in the error console

Actual:
Error console shows

TypeError: this.listTree is undefined calendar-list-tree.js:230:29
    onPropertyChanged chrome://calendar/content/widgets/calendar-list-tree.js:230
    notify resource://calendar/modules/utils/calDataUtils.jsm:40
    notify resource://calendar/modules/utils/calDataUtils.jsm:68
    setProperty resource://calendar/modules/utils/calProviderUtils.jsm:671
    set name resource://calendar/modules/utils/calProviderUtils.jsm:450
    onAcceptDialog chrome://calendar/content/calendar-properties-dialog.js:78
    _fireButtonEvent chrome://global/content/bindings/dialog.xml:433
    _doButtonCommand chrome://global/content/bindings/dialog.xml:407
    _handleButtonCommand chrome://global/content/bindings/dialog.xml:395

Proposed fix.

Attachment #9070878 - Flags: review?(paul)
Comment on attachment 9070878 [details] [diff] [review] fix against comm-beta Review of attachment 9070878 [details] [diff] [review]: ----------------------------------------------------------------- r+ Looks good to me, thanks for catching and fixing this.
Attachment #9070878 - Flags: review?(paul) → review+
Keywords: checkin-needed
Comment on attachment 9070878 [details] [diff] [review] fix against comm-beta The patch applies cleanly to comm-central as well, thus requesting checkin into both comm-central and comm-beta.
Attachment #9070878 - Flags: approval-calendar-beta?(philipp)
Assignee: nobody → public
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/be5c06a3f4d2
Fix 'this' reference in calendar-list-tree. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 7.1
Attachment #9070878 - Flags: approval-calendar-beta?(philipp) → approval-calendar-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: