1558323 - Move window.external.AddSearchProvider / IsSearchProviderInstalled to JS Window Actors, unless we decide to just remove them

Status: RESOLVED FIXED

(Firefox :: Search, task, P5)

Description

[Mike Conley (:mconley) (:⚙️)]

We seem to implement these two functions:

window.external.AddSearchProvider and window.external.IsSearchProviderInstalled here.

I believe this is a Microsoft API, and was introduced in IE7. Both methods were altered in IE10 so that they return hard-coded values.

From what I can tell, Chromium doesn't even return anything. For those.

We still support AddSearchProvider, and have a message listener for it here.

Interestingly, our own MDN page on window.external says that Firefox only implements these as dummy functions.

Can we do the same thing as IE10 or Chromium here, and just return some hard-coded values?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[jscher2000]

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #0)

Interestingly, our own MDN page on window.external says that Firefox only implements these as dummy functions.

I fixed that for the time being.

Comment 3

[Neil Deakin]

Attachment: Bug 1558323, move addSearchProvider implementation to use JSWindowActor, also helps reduce the extra code in MainProcessSingleton.jsm, r=adw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/428e0cb54f8c
move addSearchProvider implementation to use JSWindowActor, also helps reduce the extra code in MainProcessSingleton.jsm, r=adw

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/428e0cb54f8c