1558360 - PrintingChild.exitPrintPreview doesn't handle in-progress printing

Status: NEW

(Toolkit :: Printing, defect, P3)

Description

[Jonathan Watt [:jwatt]]

nsDocumentViewer::ExitPrintPreview will throw NS_ERROR_FAILURE if an actual print is ongoing. PrintingChild.exitPrintPreview does not handle this and so we'll presumably end up closing the print preview browser tab while that print is still happening. That takes us down the path of undefined behavior.

Comment 1

[Jonathan Watt [:jwatt]]

Mike, do you have any thoughts on this? Should Firefox wait for the print to finish? Maybe the print preview "Close" button should be disabled while actual prints are being processed? Or the user should be notified that they can't close print preview because the document is being printed? I guess alternatively nsDocumentViewer::ExitPrintPreview should abort the print, but that seems like poor/unexpected UX.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I think it makes sense to disable the "Close" button while the print progress dialog is open. We'll probably also want to temporarily disable the ability for users to close that browser window while in that state here.

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)

We'll probably also want to temporarily disable the ability for users to close that
browser window while in that state here.

permalink