1558442 - Use a weaker change hint for auto <-> non-auto offset changes.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

If the change hints in bug 1558357 are right, they should hold as well for other positioned stuff.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1558442 - Use a weaker change hint for auto -> non-auto offset changes. r=dbaron

See the review comments in bug 1558442 to see why these should be correct.
Quoting:

I think it would be good to avoid passing ClearDescendantIntrinsics and
NeedDirtyReflow here, since those are the most expensive ones, and I think
they're pretty clearly not needed. I think ClearAncestorIntrinsics is also
clearly not needed, since I'm reasonably confident that absolutely positioned
kids don't contribute to their parent's intrinsic size.

I think the same thing applies to "slow" offset changes (when autoness changes),
since relative movement doesn't affect intrinsic sizes either.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d82fddfaec91
Use a weaker change hint for auto -> non-auto offset changes. r=dbaron

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d82fddfaec91