15585 - [dogfood]Clean-up build warnings

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P3)

Description

[Steve Lamm]

http://tinderbox.mozilla.org/SeaMonkey/warnings.html#pnunn

The warnings about "j1" or "gamma" shadows globals come from system header files
that pollute the name space. You can find where these are initially defined by
compiling with '-E' to only preprocess the file. Maybe you have included a
header file you do not need. Otherwise, you might just change the names of your
variable so they do not conflict.

Would you also look at the warnings for hardts since he is no longer around?

Now you have a bug so you can check in your fix. =)

Comment 1

[pnunn]

I think various checkins have addressed alot of these
warnings...I'm marking m11 [dogfood] to be sure I
check that all have been fixed.

Comment 2

[pnunn]

This is down to one warning that I think
is bogus. The warning occurs for an unused variable
that lives in a debug ifdef.

I'm closing this one.
-pn

Comment 3

[Steve Lamm]

The warning does not look like an error, but it is a valid warning. The code is
an ifdef DEBUG, but ILTRACE is defined to {}, so aspect is not used.

   996                     float aspect = (float)((q[6] + 15) / 64.0);
   997                     ILTRACE(2, ("il:gif: %f aspect ratio", aspect));

Maybe add a define to the header,

#define USE_ILTRACE 1

if it is supposed to do something, then use

#ifdef USE_ILTRACE

around the block of code that gives the warning.

Comment 4

[pnunn]

what about replacing the #ifdef DEBUG block with
#ifdef USE_ILTRACE
  ....
#endif

That should be simpler and obtain the same
ultimate result. I'll test the warning on linux
and checkin after a nice build.
-pn

Comment 5

[Steve Lamm]

Sounds good.

Comment 6

[Steve Lamm]

Marking verified.