Closed
Bug 1558509
Opened 5 years ago
Closed 4 years ago
Various multicol reftest failures on geckoview (x86-64 Android 7.0 emulator)
Categories
(Core :: Layout: Columns, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla80
People
(Reporter: kats, Assigned: TYLin)
References
Details
Attachments
(3 files)
I'm turning on gecko reftests on Geckoview in bug 1501582 and as part of that annotating any failures I'm running into. There's a few failures in multicol reftests:
== css-multicol/multicol-count-computed-003.xht css-multicol/multicol-count-computed-003-ref.xht
== css-multicol/multicol-count-computed-004.xht css-multicol/multicol-count-computed-004-ref.xht
== css-multicol/multicol-count-computed-005.xht css-multicol/multicol-count-computed-003-ref.xht
== css-multicol/multicol-gap-large-001.xht css-multicol/multicol-gap-large-001-ref.xht
== css-multicol/multicol-span-all-margin-001.xht css-multicol/multicol-span-all-margin-001-ref.xht
== css-multicol/multicol-span-all-margin-002.xht css-multicol/multicol-span-all-margin-002-ref.xht
== css-multicol/multicol-span-all-margin-nested-001.xht css-multicol/multicol-span-all-margin-nested-001-ref.xht
Visually there are horizontal lines in the reference image which aren't in the test image. I'll attach screenshots of one of the failures as an example.
Reporter | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Priority: -- → P3
Updated•5 years ago
|
Whiteboard: [geckoview]
Assignee | ||
Comment 2•5 years ago
|
||
It looks like the line height of <div>
is slightly bigger than <img height="20">
on geckoview in all these test references.
Assignee | ||
Comment 3•4 years ago
|
||
All the correspond test files are using font: 1.25em/1 Ahem
, so this
patch sets the same rule to all their references to prevent default font
from resulting a line-height larger than 20px.
Updated•4 years ago
|
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b969ce96b55c Set font and line-height to some multicol reference files. r=heycam
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24671 for changes under testing/web-platform/tests
Comment 6•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Upstream PR merged by moz-wptsync-bot
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•