1558526 - registerProcessor likely crashes if aProcessorCtor.prototype.process is null

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

The code looks like this:

  if (!process.isObjectOrNull() || !JS::IsCallable(process.toObjectOrNull())) {
    aRv.ThrowTypeError<MSG_NOT_CALLABLE>(NS_LITERAL_STRING(
        "Argument 2 of AudioWorkletGlobalScope.registerProcessor "
        "constructor.process"));
    return;
  }

but JS::IsCallable assumes it's actually passed an object, not null and will crash if null is passed.

Please add a test.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1558526 remove check for callable process() in registerProcessor() r?bzbarsky

Since https://github.com/WebAudio/web-audio-api/pull/2104

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1558526 Test processor port assignment on processor callback function construction r?bzbarsky

Depends on D55227

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1558526 test use of 'process' getter for AudioWorkletProcessor callback r?bzbarsky

Comment 4

[Phabricator Automation]

Comment on attachment 9112456 [details]
Bug 1558526 Test processor port assignment on processor callback function construction r?bzbarsky

Revision D55228 was moved to bug 1565956. Setting attachment 9112456 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b02e25673b4
remove check for callable process() in registerProcessor() r=bzbarsky

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9b02e25673b4

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0f2f7500351
test use of 'process' getter for AudioWorkletProcessor callback r=bzbarsky

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21453 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f0f2f7500351

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot