1558561 - Launcher Process needs to set length in RTL_OSVERSIONINFOW before calling RtlGetVersion

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Oops.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1558561: Fix missing population of RTL_OSVERSIONINFOW::dwOSVersionInfoSize; r=mhowell!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4404389d3857
Fix missing population of RTL_OSVERSIONINFOW::dwOSVersionInfoSize; r=mhowell

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4404389d3857

Comment 5

[Julien Cristau [:jcristau]]

I think bugbug is probably wrong.

Aaron, I guess you'll want this on 68 since it's marked as blocking 1481546?

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9071343 [details]
Bug 1558561: Fix missing population of RTL_OSVERSIONINFOW::dwOSVersionInfoSize; r=mhowell!

Beta/Release Uplift Approval Request

• User impact if declined: Potential false negatives in the DLL blocklist
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One significant line changed - just initializes a variable.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9071343 [details]
Bug 1558561: Fix missing population of RTL_OSVERSIONINFOW::dwOSVersionInfoSize; r=mhowell!

launcher process fix, approved for 68.0b10

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/807e9d8f83dc