Closed Bug 1558588 Opened 6 years ago Closed 3 years ago

Remove the code that opens the print progress dialog from the core printing code

Categories

(Core :: Printing: Setup, task, P2)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Whiteboard: [print2020])

Following up on bug 1088061, we should remove the code for opening the print progress dialog in the core printing code. What UI should be shown for progress, if any, should be up to the app, not the core code. The core code should simply send progress updates to the app supplied progress listener.

Currently the Firefox frontend code opens the progress dialog itself for print preview generation, but lets the core doc open it for an actual print. I don't believe there's any reason for it to do this. We should just make the code path that does an actual print also open the progress dialog itself.

Depends on: 1558907
Blocks: 557645
Blocks: 1140929
Type: defect → task
Whiteboard: [print2020]
Status: NEW → ASSIGNED
Whiteboard: [print2020] → [print2020_v81]
Whiteboard: [print2020_v81] → [print2020_v82]

At this point this will probably happen when we drop support for the old UI which still uses this, and remove all the old code that it uses.

Whiteboard: [print2020_v82] → [print2020_v83]
Whiteboard: [print2020_v83] → [print2020_v85]
Whiteboard: [print2020_v85] → [print2020_v87]
Whiteboard: [print2020_v87] → [print2020_v88]
Whiteboard: [print2020_v88] → [print2020]

Fixed as part of bug 1745452.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.