Closed
Bug 15586
Opened 26 years ago
Closed 25 years ago
synchronous RDF/XML loads do not call observers
Categories
(Core Graveyard :: RDF, defect, P3)
Core Graveyard
RDF
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9
People
(Reporter: waterson, Assigned: waterson)
Details
Attachments
(2 files)
|
1.91 KB,
patch
|
Details | Diff | Splinter Review | |
|
3.86 KB,
patch
|
Details | Diff | Splinter Review |
Need to make sure that rdf_BlockingParse calls back to observers before and
after doing the parse.
|
Assignee | |
Updated•26 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M12
|
|
Assignee | |
Updated•26 years ago
|
Target Milestone: M12 → M20
|
|
Assignee | |
Comment 1•26 years ago
|
||
I suck.
|
|
Assignee | |
Updated•25 years ago
|
Target Milestone: --- → mozilla0.9
|
|
Assignee | |
Comment 3•25 years ago
|
||
Edge case... It is perhaps worth including a null-check, "if (obs)", for the
case where some observers remove themselves, causing the for-loop to be out
of sync and to go out of bounds.
But looking again, it seems things are sufficiently safe because the loop goes
in decreasing order... So if the i-th observer removes itself upon receiving its
notification and the array is compacted from the tail, then the (i-1)-first
index will still be pointing to the next...
|
|
Assignee | |
Comment 6•25 years ago
|
||
|
|
Assignee | |
Comment 7•25 years ago
|
||
dougt: incorporated your feedback...
1. Updated C-style casts
2. You're right: should always call OnEndLoad().
|
||
Comment 8•25 years ago
|
||
r=dougt. thanks
|
|
||
Comment 9•25 years ago
|
||
sr=alecf
|
|
Assignee | |
Comment 10•25 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•