synchronous RDF/XML loads do not call observers

VERIFIED FIXED in mozilla0.9

Status

()

Core
RDF
P3
normal
VERIFIED FIXED
19 years ago
17 years ago

People

(Reporter: Chris Waterson, Assigned: Chris Waterson)

Tracking

Trunk
mozilla0.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

19 years ago
Need to make sure that rdf_BlockingParse calls back to observers before and
after doing the parse.
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
Target Milestone: M12
(Assignee)

Updated

19 years ago
Target Milestone: M12 → M20
(Assignee)

Comment 1

19 years ago
I suck.

Comment 2

18 years ago
Guess who else run into this..
Keywords: zopestudio
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 3

17 years ago
Created attachment 25512 [details] [diff] [review]
make BlockingParse() call observers

Comment 4

17 years ago
Edge case... It is perhaps worth including a null-check, "if (obs)", for the
case where some observers remove themselves, causing the for-loop to be out
of sync and to go out of bounds.

Comment 5

17 years ago
But looking again, it seems things are sufficiently safe because the loop goes
in decreasing order... So if the i-th observer removes itself upon receiving its
notification and the array is compacted from the tail, then the (i-1)-first
index will still be pointing to the next...
(Assignee)

Comment 6

17 years ago
Created attachment 25604 [details] [diff] [review]
incorporate dougt's feedback
(Assignee)

Comment 7

17 years ago
dougt: incorporated your feedback...

1. Updated C-style casts
2. You're right: should always call OnEndLoad().

Comment 8

17 years ago
r=dougt.  thanks

Comment 9

17 years ago
sr=alecf
(Assignee)

Comment 10

17 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.