1558628 - Fix "tracking content blocked" in webcompat reports, and maybe report something better

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, defect, P1)

Description

[(no longer active)]

Bug 1517136 seems to have broken the "tracking content blocked" field we have in webcompat.com reports we have which comes from:

https://searchfox.org/mozilla-central/rev/c606cdd6d014fee4034da1702d484c0d41b604c9/browser/extensions/report-site-issue/background.js#130

Luke was telling me we may want to report something better here, but I think the very first step is to fix the regression caused there and then figure out what it is that we'd like to report instead.

Mike, can you help me figure out the priority of this bug please and which release branches the fix needs to be backported to?

Comment 1

[(no longer active)]

Attachment: Bug 1558628 - Add back nsIDocShell.hasTrackingContentBlocked since it is used in the webcompat report-site-issue extension;

Comment 3

[Mike Taylor [:miketaylr]]

It looks like Bug 1517136 regressed the behavior in 66. The good news is we only ship Report Site Issue enabled in pre-release, so if we can uplift to Beta that would be great.

Comment 4

[(no longer active)]

(In reply to Mike Taylor [:miketaylr] from comment #3)

It looks like Bug 1517136 regressed the behavior in 66. The good news is we only ship Report Site Issue enabled in pre-release, so if we can uplift to Beta that would be great.

Oh great, will do. Hopefully the added tests will prevent this from happening the next time!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d6cd9da22a2
Add back nsIDocShell.hasTrackingContentBlocked since it is used in the webcompat report-site-issue extension; r=baku

Comment 6

[(no longer active)]

Comment on attachment 9071423 [details]
Bug 1558628 - Add back nsIDocShell.hasTrackingContentBlocked since it is used in the webcompat report-site-issue extension;

Beta/Release Uplift Approval Request

• User impact if declined: Users who submit broken site reports will be submitting misleading information about whether there were any tracking content blocked on those sites.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch partly restores code that was previously there, adding one virtual function which will just be called by the report-site-issue extension and is otherwise unused in Firefox.
• String changes made/needed: none

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0d6cd9da22a2

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9071423 [details]
Bug 1558628 - Add back nsIDocShell.hasTrackingContentBlocked since it is used in the webcompat report-site-issue extension;

regression fix for webcompat extension, approved for 68.0b10

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/1f82fe365272

Comment 10

[Mike Taylor [:miketaylr]]

Thanks all.