1558646 - WPT MediaStream-MediaElement-firstframe.https.html, line 41: Error: Got unexpected event undefined

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

I noticed [1] (see the raw log) we can get an unexpected event and the test still passes. This should really fail the test.

We should also be logging the type attribute, not the name attribute (hence the log says undefined).

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6688222f39ce29bff4676b0c8e1ddf675c9d86a&selectedJob=251166070

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1558646 - Fail test by assert on, and log, unexpected events in WPT MS-ME-firstframe. r?jib

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1558646 - Unset durationchange handler in WPT MS-ME-firstframe cleanup. r?jib

Stopping the tracks as happens in cleanup makes the media element end playback,
which fires durationchange. It doesn't fail the test since it already finished,
but having it show up in the log is distracting.

Depends on D34707

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a859291efa4e
Fail test by assert on, and log, unexpected events in WPT MS-ME-firstframe. r=jib
https://hg.mozilla.org/integration/autoland/rev/d5b7f97785fa
Unset durationchange handler in WPT MS-ME-firstframe cleanup. r=jib

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17312 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a859291efa4e
https://hg.mozilla.org/mozilla-central/rev/d5b7f97785fa

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged