1558726 - Stop using [array] in nsISocketTransportService

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1558726. Stop using [array] in nsISocketTransportService. r=dragana

Comment 2

[Boris Zbarsky [:bzbarsky]]

Jorg, this will need some comm-central changes.

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks. I see looking at bug 1509981 that there is plenty more to come. EDIT: I checked the other ones, looks like the don't affect TB unless I missed something. So please keep the heads-up coming.

This one here is for nsISocketTransportService.create{Routed}Transport.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1558536-c-c-part-nsISocketTransportService.patch

Hi Boris, please let me know if you want me to move smaller patches like this one into a different bug and find another reviewer.

EDIT: I haven't compiled this.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 9071553 [details] [diff] [review]
1558536-c-c-part-nsISocketTransportService.patch

>+++ b/mail/components/accountcreation/content/guessConfig.js
>   var socketTypeName = null;
>   if (ssl == SSL) {
>     socketTypeName = "ssl";
>   } else if (ssl == TLS) {
>     socketTypeName = "starttls";
>   }

I think this would be clearer as:

  var socketTypeName = [];
  if (ssl == SSL) {
    socketTypeName.push("ssl");
  } else if (ssl == TLS) {
    socketTypeName.push("starttls");
  }

and then

  var transport = transportService.createTransport(socketTypeName, hostname, port, proxy);

>+++ b/mailnews/base/util/nsMsgProtocol.cpp
>+  if (connectionType)
>+    connectionTypeArray.AppendElement(nsDependentCString(connectionType));

You can just AppendElement(connectionType), fwiw.

>+++ b/mailnews/imap/src/nsImapProtocol.cpp
>+  if (connectionType)
>+    connectionTypeArray.AppendElement(nsDependentCString(connectionType));

Again, no need for nsDependentCString.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1558536-c-c-part-nsISocketTransportService.patch (v2)

Thanks, Boris, took your suggestions on board. Geoff, I can't r? here, so the f? is an r?

Comment 7

[Jorg K (CEST = GMT+2)]

You need to stick on an r+ :-)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3bd88cde793
Stop using [array] in nsISocketTransportService.  r=dragana

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e3bd88cde793