Closed Bug 1558743 Opened 1 year ago Closed 1 year ago

Followup from Bug 1531338 - Current permission for block autoplay is not visible in Site information panel with high contrast enabled

Categories

(Core :: Widget: Gtk, defect, P2)

Desktop
Linux
defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox68 --- verified
firefox69 --- verified

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(2 files)

Fixes landed at Bug 1531338 are incomplete and needs to be finished.

+++ This bug was initially created as a clone of Bug #1531338 +++

Affected versions
*Fx 66.0b11

Affected platforms

  • Ubuntu 18.04 x64 LTS

Steps to reproduce

  1. Enable High Contrast in Ubuntu
  2. Open Firefox.
  3. Reach https://edition.cnn.com/videos
  4. Open the site information panel.
  5. Click on the autoplay Allow/Block drop down menu.

Expected result

  • The drop down menu displays the current setting and the Allow/Block settings

Actual result

  • The drop down menu only displays the Allow/Block, and the current setting is not visible because its black text on a black background.

Regression range

  • Will return ASAP with a regression range.
Keywords: access

It's interesting that the simple testcase:

data:text/html,<button>Press%20and%20Hold

works as expected (also the dropdowns at Customize) but the Video permission dialog is broken. I wonder if it uses a different component or some custom colors.

I recently see two cases where the text color is wrong:

  • CNN Video permissions
  • Dialog button when closing more that one tab
Keywords: checkin-needed

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82a69faa3470
Don't change button text color for default buttons, r=dao
https://hg.mozilla.org/integration/autoland/rev/abfcff34c77a
Use -moz-gtk-buttonactivetext for active menulist buttons, r=dao

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Please nominate this for Beta approval when you get a chance.

Flags: qe-verify+
Flags: needinfo?(stransky)

Comment on attachment 9071566 [details]
Bug 1558743 - Don't change button text color for default buttons, r=dao

Beta/Release Uplift Approval Request

  • User impact if declined: Default buttons has wrong text color when HiContrast system theme is used.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Linux/theme bug.
  • String changes made/needed: none
Flags: needinfo?(stransky)
Attachment #9071566 - Flags: approval-mozilla-beta?

Comment on attachment 9071567 [details]
Bug 1558743 - Use -moz-gtk-buttonactivetext for active menulist buttons, r=dao

Beta/Release Uplift Approval Request

  • User impact if declined: Site autoplay permissions button has wrong text color when HiContrast system theme is used.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: - install tweak tool, set HiContrast system theme
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): linux/gtk theming fix.
  • String changes made/needed: none
Attachment #9071567 - Flags: approval-mozilla-beta?
QA Whiteboard: [qa-triaged]

Comment on attachment 9071566 [details]
Bug 1558743 - Don't change button text color for default buttons, r=dao

gtk css fix, approved for 68.0b12

Attachment #9071566 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9071567 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hello,

I verified this bug on the latest Fx Nightly 69.0a1 BuildID: 20190621093603 and on Fx Beta 68.0a12. I can confirm that this issue is fixed.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.