1558743 - Followup from Bug 1531338 - Current permission for block autoplay is not visible in Site information panel with high contrast enabled

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Fixes landed at Bug 1531338 are incomplete and needs to be finished.

+++ This bug was initially created as a clone of Bug #1531338 +++

Affected versions
*Fx 66.0b11

Affected platforms

• Ubuntu 18.04 x64 LTS

Steps to reproduce

1. Enable High Contrast in Ubuntu
2. Open Firefox.
3. Reach https://edition.cnn.com/videos
4. Open the site information panel.
5. Click on the autoplay Allow/Block drop down menu.

Expected result

• The drop down menu displays the current setting and the Allow/Block settings

Actual result

• The drop down menu only displays the Allow/Block, and the current setting is not visible because its black text on a black background.

Regression range

• Will return ASAP with a regression range.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

It's interesting that the simple testcase:

data:text/html,<button>Press%20and%20Hold

works as expected (also the dropdowns at Customize) but the Video permission dialog is broken. I wonder if it uses a different component or some custom colors.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I recently see two cases where the text color is wrong:

• CNN Video permissions
• Dialog button when closing more that one tab

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1558743 - Don't change button text color for default buttons, r=dao

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1558743 - Use -moz-gtk-buttonactivetext for active menulist buttons, r=dao

Depends on D34690

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82a69faa3470
Don't change button text color for default buttons, r=dao
https://hg.mozilla.org/integration/autoland/rev/abfcff34c77a
Use -moz-gtk-buttonactivetext for active menulist buttons, r=dao

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/82a69faa3470
https://hg.mozilla.org/mozilla-central/rev/abfcff34c77a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9071566 [details]
Bug 1558743 - Don't change button text color for default buttons, r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Default buttons has wrong text color when HiContrast system theme is used.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux/theme bug.
• String changes made/needed: none

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9071567 [details]
Bug 1558743 - Use -moz-gtk-buttonactivetext for active menulist buttons, r=dao

Beta/Release Uplift Approval Request

• User impact if declined: Site autoplay permissions button has wrong text color when HiContrast system theme is used.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - install tweak tool, set HiContrast system theme

• open browser, go to https://edition.cnn.com/videos
• click on the autoplay icon in address bar and press the autoplay permission button
• the button should have readable text color
  see https://bugzilla.mozilla.org/show_bug.cgi?id=1531338 for details.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): linux/gtk theming fix.
• String changes made/needed: none

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9071566 [details]
Bug 1558743 - Don't change button text color for default buttons, r=dao

gtk css fix, approved for 68.0b12

Comment 11

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c5232da74a4
https://hg.mozilla.org/releases/mozilla-beta/rev/ac99437a9c7a

Comment 12

[Daniel Cicas [:dcicas], Release QA]

Hello,

I verified this bug on the latest Fx Nightly 69.0a1 BuildID: 20190621093603 and on Fx Beta 68.0a12. I can confirm that this issue is fixed.