1558756 - Add Jest unit tests for React components

Status: RESOLVED FIXED

(DevTools :: Application Panel, task, P1)

Description

[Belén [:ladybenko]]

Add Jest tests for our components:

• WorkerList
• WorkerListEmpty
• Worker
• App

Comment 1

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

Attachment: Bug 1558756 - Adding jest tests for components, r=jdescottes!, ladybenko!

added more jest test for components including snapshots + fixtures

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/266931d06efb
Adding jest tests for components, r=ladybenko,jdescottes

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 266931d06efb (Bug 1558756) for causing devtools failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/4382f734fc377bbe7433fa6d58e58cd732ae4c82

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=4382f734fc377bbe7433fa6d58e58cd732ae4c82&fromchange=266931d06efb975e630a88f7ba422aef8ffbebaa&selectedJob=257888533

Failure log:

• https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257888533&repo=autoland&lineNumber=587
  [task 2019-07-23T14:50:22.713Z] Snapshot Summary
  [task 2019-07-23T14:50:22.713Z] › 2 snapshots failed from 1 test suite. Inspect your code changes or run yarn run test-ci -u to update them.
  [task 2019-07-23T14:50:22.713Z]
  [task 2019-07-23T14:50:22.713Z] Test Suites: 1 failed, 2 passed, 3 total
  [task 2019-07-23T14:50:22.713Z] Tests: 2 failed, 4 passed, 6 total
  [task 2019-07-23T14:50:22.713Z] Snapshots: 2 failed, 4 passed, 6 total
  [task 2019-07-23T14:50:22.713Z] Time: 5.642s
  [task 2019-07-23T14:50:22.713Z] Ran all test suites.
  [task 2019-07-23T14:50:22.713Z] error Command failed with exit code 1.
  [task 2019-07-23T14:50:22.713Z]
  [task 2019-07-23T14:50:22.713Z] [devtools-node-test-runner] Parse errors from the test logs
  [task 2019-07-23T14:50:22.713Z] TEST-UNEXPECTED-FAIL | jest | application | ● Service Worker List: › renders the expected snapshot for a workerList with single worker list
  [task 2019-07-23T14:50:22.713Z] TEST-UNEXPECTED-FAIL | jest | application | ● Service Worker List: › renders the expected snapshot for a workerList with multiple workers list
  [task 2019-07-23T14:50:22.713Z] [devtools-node-test-runner] Test suite [application] failed
  [taskcluster 2019-07-23 14:50:23.200Z] === Task Finished ===
  [taskcluster 2019-07-23 14:50:23.200Z] Unsuccessful task run with exit code: 1 completed in 292.077 seconds

Comment 4

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

The issue is solved. Waiting on try as an intermittent occurred.

Comment 5

[Ola Gasidlo [:ogasidlo] [:ola] OOO - please ping :ladybenko:]

Should be back in the queue.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ba90a7d4a46
Adding jest tests for components, r=ladybenko,jdescottes

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3ba90a7d4a46