Log timestamp from page load recordings

RESOLVED FIXED in Firefox 69

Status

enhancement
P2
normal
RESOLVED FIXED
Last month
25 days ago

People

(Reporter: davehunt, Assigned: ariakab)

Tracking

(Blocks 1 bug)

Version 3
mozilla69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(2 attachments)

We'd like to increase the visibility of when page recordings are updated. A first step would be to extract and log the timestamp from the recording. For mitmproxy, the recordings have many matches for 'timestamp' so we should just find an appropriate and consistently available match to convert to date/time for logging.

Priority: -- → P2
Assignee: nobody → ariakab
Status: NEW → ASSIGNED

This will require some changes in different places:

  1. Raptor studio:

Update raptor studio record plugin to save the current date in the json file it creates at record time.
This is added in pull:
https://github.com/mozilla/raptor-studio/pull/16
See:
https://github.com/mozilla/raptor-studio/pull/16/files#diff-61ec0cd7c664286456ae66ff26aa7e9b

the format of the json should be:

{
  "record_date": "",
  "protocol": {
    "detectportal.firefox.com": "HTTP/1.1"
    }
}
  1. Update Alternate server replay to read the new json format
  2. In Raptor before starting the proxy check if the Json file is available and output the date the recording was made in the logs.

This will pave the way for accessing other information about the recordings

Pushed by fstrugariu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/405087ccd676
Log timestamp from page load recordings r=perftest-reviewers,Bebe
Pushed by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9243653712d
Fix linting failure. r=Bebe CLOSED TREE
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

The only message I have seen in the logs doing a quick manual inspection is:
16:41:04 INFO - raptor-main Info: Playback recording information not available.

Hi! Did you inspect a test that runs a recently recorded site? Old recordings don't have a json file from where the recording information is being taken.

Flags: needinfo?(mtrinkala)

No, I was just looking at the test runs associated with this patch as it is unclear to me what other runs should include this data. Is there a specific test in there I should be looking at with a recently recorded site?... In any case I will setup some automation to look at them all.

Flags: needinfo?(mtrinkala)

I think that there were no tests that had a json file, except the one for Netflix I guess. We started re-recording after this patch landed.

Here's an example from treeherder:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253865308&repo=mozilla-central&lineNumber=631

You need to log in before you can comment on or make changes to this bug.