Closed Bug 1558779 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17288 - Revert "Active Processing for ConvolverNode"

Categories

(Testing :: web-platform-tests, defect, P4)

Product:
Testing
Component:
web-platform-tests
Type:
defect

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17288 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17288
Details from upstream follow.

Findit <findit-for-me@appspot.gserviceaccount.com> wrote:

Revert "Active Processing for ConvolverNode"

This reverts commit 499976c54a2b086bbde54ae137d0ac4adb3cd427.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 668149 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDk5OTc2YzU0YTJiMDg2YmJkZTU0YWUxMzdkMGFjNGFkYjNjZDQyNww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/15474

Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6

Sample Flaky Test: external/wpt/webaudio/the-audio-api/the-convolvernode-interface/active-processing.https.html

Original change's description:

Active Processing for ConvolverNode

The ConvolverNode should output a single channel of silence when it is not
actively processing. Active processing is already supported and just needed
to have the convolver output a single channel of silence when it is
constructed, before anything is connected to it.

Bug: 971389
Change-Id: Icc894cd7ea6dec60a1eccb0fa4a3aea68ac5b51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644899
Commit-Queue: Raymond Toy \<rtoy@chromium.org>
Reviewed-by: Hongchan Choi \<hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668149}

Change-Id: Ie7fedee332ca167c3dfd4fd99142de89234ff03a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 971389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653924
Cr-Commit-Position: refs/heads/master@{#668243}

PR 17288 applied with additional changes from upstream: 6531eab802391a24dabca973cc4329abbeadd896
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3894cee297 [wpt PR 17288] - Revert "Active Processing for ConvolverNode", a=testonly

https://hg.mozilla.org/mozilla-central/rev/9f3894cee297

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream error]
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17722 for changes under testing/web-platform/tests
Whiteboard: [wptsync upstream error] → [wptsync upstream]
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/26d9d83f4871 [wpt PR 17722] - [Gecko Bug 1558779] [wpt PR 17288] - Revert "Active Processing for ConvolverNode", a=testonly, a=testonly
You need to log in before you can comment on or make changes to this bug.