Closed Bug 1558797 Opened 5 years ago Closed 5 years ago

Intermittent test-verify dom/canvas/test/test_imagebitmap.html | Did not get SecurityError with unclean source. ImageBitmap was created successfully.

Categories

(Core :: Graphics: Canvas2D, defect, P3)

Product:
Core
Component:
Graphics: Canvas2D
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Filed by: dluca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=251347439&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/DGWPg3ESTByLQF03IbOtHQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/DGWPg3ESTByLQF03IbOtHQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

TEST-PASS | dom/canvas/test/test_imagebitmap.html | ImageBitmaps are always created
10:01:44 INFO - TEST-PASS | dom/canvas/test/test_imagebitmap.html | SecurityError: The operation is insecure.
10:01:44 INFO - TEST-PASS | dom/canvas/test/test_imagebitmap.html | ImageBitmaps are always created
10:01:44 INFO - Buffered messages finished
10:01:44 INFO - TEST-UNEXPECTED-FAIL | dom/canvas/test/test_imagebitmap.html | Did not get SecurityError with unclean source. ImageBitmap was created successfully.
10:01:44 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
10:01:44 INFO - checkPromiseFailedWithSecurityError/<@dom/canvas/test/test_imagebitmap.html:279:9
10:01:44 INFO - promise callbackcheckPromiseFailedWithSecurityError@dom/canvas/test/test_imagebitmap.html:273:14
10:01:44 INFO - testSecurityErrors@dom/canvas/test/test_imagebitmap.html:294:5
10:01:44 INFO - promise callbackrunTests@dom/canvas/test/test_imagebitmap.html:346:6
10:01:44 INFO - rval@SimpleTest/SimpleTest.js:146:30
10:01:44 INFO - EventHandlerNonNullthis.addLoadEvent@SimpleTest/SimpleTest.js:171:13
10:01:44 INFO - @SimpleTest/SimpleTest.js:1453:5
10:01:44 INFO - TEST-PASS | dom/canvas/test/test_imagebitmap.html | ImageBitmaps are always created
10:01:44 INFO - Not taking screenshot here: see the one that was previously logged
10:01:44 INFO - TEST-UNEXPECTED-FAIL | dom/canvas/test/test_imagebitmap.html | Did not get SecurityError with unclean source. ImageBitmap was created successfully.
10:01:44 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
10:01:44 INFO - checkPromiseFailedWithSecurityError/<@dom/canvas/test/test_imagebitmap.html:279:9
10:01:44 INFO - promise callbackcheckPromiseFailedWithSecurityError@dom/canvas/test/test_imagebitmap.html:273:14
10:01:44 INFO - testSecurityErrors@dom/canvas/test/test_imagebitmap.html:295:5
10:01:44 INFO - promise callbackrunTests@dom/canvas/test/test_imagebitmap.html:346:6
10:01:44 INFO - rval@SimpleTest/SimpleTest.js:146:30
10:01:44 INFO - EventHandlerNonNullthis.addLoadEvent@SimpleTest/SimpleTest.js:171:13
10:01:44 INFO - @SimpleTest/SimpleTest.js:1453:5
10:01:44 INFO - TEST-PASS | dom/canvas/test/test_imagebitmap.html | ImageBitmaps are always created
10:01:44 INFO - TEST-PASS | dom/canvas/test/test_imagebitmap.html | SecurityError: The operation is insecure.
10:01:44 INFO - TEST-PASS | dom/canvas/test/test_imagebitmap.html | The promise should be rejected with InvalidStateError.

Mark this appeared when bug 1558527 landed, could you please take a look?

Flags: needinfo?(standard8)
Regressed by: 1558527

From looking at https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0f878938a014691f65798f2f2292f6cfdf57cd0f and https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1558797&startday=2019-06-12&endday=2019-06-12&tree=all

This is all just test-verify.

I can reproduce it without the patch from bug 1558527 applied, so I think this is a pre-existing issue. The code I'm touching in the test is also after the failure occurs in this file.

Flags: needinfo?(standard8)
Summary: Intermittent dom/canvas/test/test_imagebitmap.html | Did not get SecurityError with unclean source. ImageBitmap was created successfully. → Intermittent test-verify dom/canvas/test/test_imagebitmap.html | Did not get SecurityError with unclean source. ImageBitmap was created successfully.
No longer regressed by: 1558527

(In reply to Mark Banner (:standard8) from comment #3)

From looking at https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0f878938a014691f65798f2f2292f6cfdf57cd0f and https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1558797&startday=2019-06-12&endday=2019-06-12&tree=all

This is all just test-verify.

I can reproduce it without the patch from bug 1558527 applied, so I think this is a pre-existing issue. The code I'm touching in the test is also after the failure occurs in this file.

Afaic, TV is the first indicator to a sure culprit. Sebastian can you clarify?

Flags: needinfo?(aryx.bugmail)

The subtests are promises, their order of progress isn't deterministic. The failure didn't get triggered when bug 1502799 landed 7 months ago. Sounds like the behavior / consequences of the test in test-verify has changed since that time.

Flags: needinfo?(aryx.bugmail)

The priority flag is not set for this bug.
:lsalzman, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(lsalzman)
Flags: needinfo?(lsalzman)
Priority: -- → P3
Regressed by: 1502799
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Whiteboard: [stockwell needswork:owner]
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.