1558800 - Firefox Hebrew: Morfix Search is broken

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Yaron]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Type "Test" in the Search Box.
Press the Morfix icon.

Actual results:

לא נמצא תרגום מילוני עבור default.aspx
(Translation for "default.aspx" was not found).

Comment 1

[David Sacal]

Hi Yaron,
i was able to reproduce this behavior on the latest release (67.0.4) but i do not know the expected results. I will assign a component in the meantime but please come back with detailed info in order to confirm the following steps.

Regards
David

Comment 2

[Mark Banner (:standard8)]

Flod/Itiel, could you help out here please?

It looks like the site has changed its design and we should probably be pointing to some different / new URL.

Comment 3

[Yaron]

Hello David and Mark,

The expected result is "Test" being translated.

Changing the following lines in morfix-dic.xml

  <Url type="text/html" method="GET" template="http://milon.morfix.co.il/default.aspx" resultdomain="morfix.co.il">
    <Param name="q" value="{searchTerms}"/>
  </Url>
  <SearchForm>http://milon.morfix.co.il/</SearchForm>

to

  <Url type="text/html" method="GET" template="https://morfix.co.il/{searchTerms}" resultdomain="morfix.co.il">
  </Url>
  <SearchForm>https://morfix.co.il/</SearchForm>

partially solves the problem: "Test" is translated but "My Test" results in a "Server Not Found" error.
{searchTerms} passes ""My+Test" whereas the site expects "My Test".

The following code works in a JS file.

(async function () {
    "use strict";

    browser.menus.create({
        id: "MorfixSearch",
		title: "חפש במורפיקס את \"%s\"",
        contexts: ["selection"]
    });

    browser.menus.onClicked.addListener(async (info, tab) => {
        if (info.menuItemId !== "MorfixSearch" || !info.selectionText)
            return;

        let url = new URL("https://morfix.co.il");
        await browser.tabs.create({
			index: tab.index + 1,
            url: url.href + info.selectionText.trim()
        });
    });
}());

Note the line url: url.href + info.selectionText.trim().

Comment 4

[Itiel]

I've contacted Morfix to see how they can help.

NI? also to Tomer.

Comment 5

[Yaron]

Thank you Itiel.

Comment 6

[Yaron]

Replacing the following lines in morfix-dic.xml

  <Url type="text/html" method="GET" template="http://milon.morfix.co.il/default.aspx" resultdomain="morfix.co.il">
    <Param name="q" value="{searchTerms}"/>
  </Url>
  <SearchForm>http://milon.morfix.co.il/</SearchForm>

with

  <Url type="text/html" method="GET" template="https://www.morfix.co.il/{searchTerms}" resultdomain="morfix.co.il">
  </Url>
  <SearchForm>https://www.morfix.co.il/</SearchForm>

solves the problem.

Comment 7

[ofryli]

Hi guys,
I'm the developer of the search addon -
https://addons.mozilla.org/en-US/android/addon/morfix/
Watch out if you using https://morfix.co.il/ and not https://www.morfix.co.il/ it's gonna bring you troubles.

Comment 8

[Dale Harvey (:daleharvey)]

Attachment: Bug 1558800 - Update url for morfix search engine. r?Standard8

Comment 9

[Yaron]

@Dale,

Why not modify morfix-dic.xml?

Thank you.

Comment 10

[Dale Harvey (:daleharvey)]

Yaron, we replaced morfix-dic.xml with morfix-dic/manifest.json, all built in search engines are loaded as web extensions now, the opensearch definitions have been deleted

Comment 11

[Francesco Lodolo [:flod]]

(In reply to Yaron from comment #9)

Why not modify morfix-dic.xml?

To clarify the last comment. XML have been replaced from version 68, only 67 still have the OpenSearch format.

Comment 12

[Yaron]

Great.
Thank you Dale and Francesco.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/580ca9880dfa
Update url for morfix search engine. r=Standard8

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/580ca9880dfa