Closed Bug 1558823 Opened 5 years ago Closed 5 years ago

Addons without icon should show something (default addon-icon)

Categories

(Toolkit :: Add-ons Manager, defect, P3)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- fixed
firefox67 --- disabled
firefox68 --- wontfix
firefox69 --- verified
firefox70 --- verified

People

(Reporter: metasieben, Assigned: Oriol, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(3 files)

The HTML version of about:addons displays a broken image-icon
instead of the generic-addon-icon if the addon has no icon(src=null).

The XUL version used, chrome://mozapps/skin/extensions/extensionGeneric.svg
as a fallback.

Attached image listing without icon
Blocks: 1505924
Priority: -- → P3
Mentor: mstriemer
Assignee: nobody → oriol-bugzilla
Keywords: checkin-needed
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: checkin-needed
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/278205a39cd8
Show generic icon for extensions without icon. r=mstriemer,mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Verified the fix with the latest Nightly (70.0a1 / 20190711230342) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.

The default add-on icon is displayed for extensions which do not have an icon, confirming the fix.

The issue still occurs as described in the latest Beta and Release versions.

Status: RESOLVED → VERIFIED
Attached image 2019-07-12_12h54_21.png

Please nominate this for Beta & ESR68 approval when you get a chance.

Flags: needinfo?(oriol-bugzilla)
Flags: in-testsuite+

Comment on attachment 9075618 [details]
Bug 1558823 - Show generic icon for extensions without icon. r?mstriemer

Beta/Release Uplift Approval Request

  • User impact if declined: Broken image icon in about:addons for extensions with no icon
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just shows the generic icon if no icon is provided
  • String changes made/needed:
Attachment #9075618 - Flags: approval-mozilla-beta?

Comment on attachment 9075618 [details]
Bug 1558823 - Show generic icon for extensions without icon. r?mstriemer

Shows a generic placeholder icon instead of nothing in the addons manager for extensions without an icon. Approved for 69.0b5 and 68.1esr.

Flags: needinfo?(oriol-bugzilla)
Attachment #9075618 - Flags: approval-mozilla-esr68+
Attachment #9075618 - Flags: approval-mozilla-beta?
Attachment #9075618 - Flags: approval-mozilla-beta+

Verified the fix with the latest Beta (69.0b5 / 20190715173502) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.

The default add-on icon is properly displayed for extensions which do not have an icon.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: