Addons without icon should show something (default addon-icon)
Categories
(Toolkit :: Add-ons Manager, defect, P3)
Tracking
()
People
(Reporter: metasieben, Assigned: Oriol, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(3 files)
9.85 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr68+
|
Details | Review |
3.45 KB,
image/png
|
Details |
The HTML version of about:addons displays a broken image-icon
instead of the generic-addon-icon if the addon has no icon(src=null).
The XUL version used, chrome://mozapps/skin/extensions/extensionGeneric.svg
as a fallback.
Reporter | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/278205a39cd8 Show generic icon for extensions without icon. r=mstriemer,mixedpuppy
Comment 4•5 years ago
|
||
bugherder |
Comment 5•5 years ago
•
|
||
Verified the fix with the latest Nightly (70.0a1 / 20190711230342) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.
The default add-on icon is displayed for extensions which do not have an icon, confirming the fix.
The issue still occurs as described in the latest Beta and Release versions.
Comment 6•5 years ago
|
||
Comment 7•5 years ago
|
||
Please nominate this for Beta & ESR68 approval when you get a chance.
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9075618 [details]
Bug 1558823 - Show generic icon for extensions without icon. r?mstriemer
Beta/Release Uplift Approval Request
- User impact if declined: Broken image icon in about:addons for extensions with no icon
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Just shows the generic icon if no icon is provided
- String changes made/needed:
Comment 9•5 years ago
|
||
Comment on attachment 9075618 [details]
Bug 1558823 - Show generic icon for extensions without icon. r?mstriemer
Shows a generic placeholder icon instead of nothing in the addons manager for extensions without an icon. Approved for 69.0b5 and 68.1esr.
Comment 10•5 years ago
|
||
bugherder uplift |
Comment 11•5 years ago
|
||
bugherder uplift |
Comment 12•5 years ago
|
||
Verified the fix with the latest Beta (69.0b5 / 20190715173502) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.
The default add-on icon is properly displayed for extensions which do not have an icon.
Description
•