1558915 - Use infallible nsIURI::SchemeIs

Status: RESOLVED FIXED

(Core :: Networking, task, P3)

Description

[Tom S [:evilpie]]

The infallible variant of SchemeIs is actually not used at all. I guess we should switch most fallible uses to that function?

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1558915 - Use infallible nsIURI::SchemeIs in dom/security. r?ckerschb

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1558915 - Use infallible nsIURI::SchemeIs in dom/base. r?smaug

Depends on D39779

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d251fbeed0f7
Use infallible nsIURI::SchemeIs in dom/security. r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/d6ac4ac8610a
Use infallible nsIURI::SchemeIs in dom/base. r=smaug

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d251fbeed0f7
https://hg.mozilla.org/mozilla-central/rev/d6ac4ac8610a

Comment 5

[Tom S [:evilpie]]

Attachment: Bug 1558915 - Use infallible nsIURI::SchemeIs in dom/. r?smaug

Comment 6

[Tom S [:evilpie]]

Attachment: Bug 1558915 - Use infallible nsIURI::SchemeIs in toolkit/ r?ehsan!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3da6e9e86be4
Use infallible nsIURI::SchemeIs in dom/. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e44c9fd81e5b
Use infallible nsIURI::SchemeIs in toolkit/ r=Ehsan

Comment 8

[Alexandru Michis [:malexandru]]

Backed out 2 changesets for causing bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/418858fa823396ccc16c9cefb1b482228d7da747

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=259549241&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=e44c9fd81e5b0455f608127e09e98a51a5a49253

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=259549245&repo=autoland&lineNumber=26152

[task 2019-08-02T09:13:06.821Z] 09:13:06 ERROR - /builds/worker/workspace/build/src/toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.cpp:180:8: error: unused variable 'match' [-Werror,-Wunused-variable]

[task 2019-08-02T09:13:36.584Z] 09:13:36 ERROR - /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:1010:3: error: use of undeclared identifier 'rv'
[task 2019-08-02T09:13:36.584Z] 09:13:36 INFO - rv = aServerURL->GetSpec(spec);
[task 2019-08-02T09:13:36.584Z] 09:13:36 INFO - ^
[task 2019-08-02T09:13:36.589Z] 09:13:36 ERROR - /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:1011:21: error: use of undeclared identifier 'rv'
[task 2019-08-02T09:13:36.589Z] 09:13:36 INFO - NS_ENSURE_SUCCESS(rv, rv);
[task 2019-08-02T09:13:36.589Z] 09:13:36 INFO - ^
[task 2019-08-02T09:13:36.589Z] 09:13:36 ERROR - /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:1011:25: error: use of undeclared identifier 'rv'

[task 2019-08-02T09:13:42.431Z] 09:13:42 ERROR - /builds/worker/workspace/build/src/toolkit/mozapps/extensions/AddonContentPolicy.cpp:114:8: error: unused variable 'equals' [-Werror,-Wunused-variable]
[task 2019-08-02T09:13:42.431Z] 09:13:42 INFO - bool equals;
[task 2019-08-02T09:13:42.431Z] 09:13:42 INFO - ^
[task 2019-08-02T09:13:42.431Z] 09:13:42 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/toolkit/mozapps/extensions/Unified_cpp_mozapps_extensions0.cpp:20:
[task 2019-08-02T09:13:42.431Z] 09:13:42 ERROR - /builds/worker/workspace/build/src/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp:66:3: error: use of undeclared identifier 'rv'
[task 2019-08-02T09:13:42.431Z] 09:13:42 INFO - rv = uri->GetHost(host);
[task 2019-08-02T09:13:42.431Z] 09:13:42 INFO - ^
[task 2019-08-02T09:13:42.431Z] 09:13:42 ERROR - /builds/worker/workspace/build/src/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp:67:17: error: use of undeclared identifier 'rv'

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d27ca6d890f
Use infallible nsIURI::SchemeIs in dom/. r=smaug

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6d27ca6d890f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0096372c462
Use infallible nsIURI::SchemeIs in toolkit/ r=Ehsan

Comment 12

[Tom S [:evilpie]]

Attachment: Bug 1558915 - Use infallible nsIURI::SchemeIs in image/ r?tnikkel!

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c0096372c462

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfa76bace85c
Use infallible nsIURI::SchemeIs in image/ r=tnikkel

Comment 15

[Tom S [:evilpie]]

Attachment: Bug 1558915 - Use infallible nsIURI::SchemeIs in uriloader/ r?bzbarsky!

Comment 16

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/dfa76bace85c

Comment 17

[Tom S [:evilpie]]

Attachment: Bug 1558915 - Use infallible nsIURI::SchemeIs in various places r?ehsan!

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c47bc0881be0
Use infallible nsIURI::SchemeIs in uriloader/ r=bzbarsky

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b197ca57677a
Use infallible nsIURI::SchemeIs in various places r=Ehsan

Comment 20

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=b197ca57677a53479a62715c6abc99ed4b50c0ab&selectedJob=260210701

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=260210701&repo=autoland&lineNumber=19889

Backout: https://hg.mozilla.org/integration/autoland/rev/cc23537316c189cb611e54d4e2cb7f041d331540

Comment 21

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c47bc0881be0

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca88862d6b63
Use infallible nsIURI::SchemeIs in various places r=Ehsan

Comment 23

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d3f1ebf7ba7
Backed out changeset ca88862d6b63 for causing build bustages on StartupCacheUtils. CLOSED TREE

Comment 24

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=ca88862d6b63ca3edf1f853c5e58ea5d1b5fbfd4

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=260318375&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/6d3f1ebf7ba7

[task 2019-08-07T10:12:15.335Z] 10:12:15 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/startupcache/Unified_cpp_startupcache0.cpp:11:0:
[task 2019-08-07T10:12:15.336Z] 10:12:15 INFO - /builds/worker/workspace/build/src/startupcache/StartupCacheUtils.cpp: In function 'nsresult mozilla::scache::PathifyURI(nsIURI*, nsACString&)':
[task 2019-08-07T10:12:15.336Z] 10:12:15 ERROR - /builds/worker/workspace/build/src/startupcache/StartupCacheUtils.cpp:197:8: error: unused variable 'equals' [-Werror=unused-variable]
[task 2019-08-07T10:12:15.336Z] 10:12:15 INFO - bool equals;
[task 2019-08-07T10:12:15.336Z] 10:12:15 INFO - ^~~~~~
[task 2019-08-07T10:12:15.336Z] 10:12:15 INFO - cc1plus: all warnings being treated as errors
[task 2019-08-07T10:12:15.337Z] 10:12:15 INFO - /builds/worker/workspace/build/src/config/rules.mk:786: recipe for target 'Unified_cpp_startupcache0.o' failed
[task 2019-08-07T10:12:15.337Z] 10:12:15 ERROR - make[4]: *** [Unified_cpp_startupcache0.o] Error 1
[task 2019-08-07T10:12:15.338Z] 10:12:15 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/startupcache'
[task 2019-08-07T10:12:15.338Z] 10:12:15 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'startupcache/target' failed
[task 2019-08-07T10:12:15.339Z] 10:12:15 ERROR - make[3]: *** [startupcache/target] Error 2
[task 2019-08-07T10:12:15.339Z] 10:12:15 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-08-07T10:12:15.340Z] 10:12:15 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/gfx/thebes'
[task 2019-08-07T10:12:15.340Z] 10:12:15 INFO - gfx/thebes/gfxGdkNativeRenderer.o

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a4e01e2d89a
Use infallible nsIURI::SchemeIs in various places r=Ehsan

Comment 26

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3a4e01e2d89a

Comment 27

[Tom S [:evilpie]]

Attachment: Bug 1558915 - Use infallible nsIURI::SchemeIs in netwerk/. r?baku!

Sorry I had some problems figuring out who can review netwerk/. Most people seem to be on PTO.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/000157acfe10
Use infallible nsIURI::SchemeIs in netwerk/. r=baku

Comment 29

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/000157acfe10

Comment 30

[Tom S [:evilpie]]

Attachment: Bug 1558915 - Use infallible nsIURI::SchemeIs everywhere. r?smaug

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d39ec9446c3
Use infallible nsIURI::SchemeIs everywhere. r=smaug

Comment 32

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6d39ec9446c3