1558933 - scrollbar-zoom-resolution-1.html fails with WebRender and the recent picture caching changes.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Glenn Watson [:gw]]

In https://bugzilla.mozilla.org/show_bug.cgi?id=1558106 (which is not quite ready to land yet), I have disabled the scrollbar-zoom-resolution-1.html when WR is enabled.

What happens is that the test case doesn't display any scroll bars, because they are overwritten by the content frame.

Logging the values from the display list in add_scroll_frame:

add_scroll_frame TypedRect(784.0×984.0 at (0.0,0.0)) 9008.0×20016.0 SpatialNodeIndex(6)
add_scroll_frame TypedRect(784.0×984.0 at (0.0,0.0)) 4508.0×10016.0 SpatialNodeIndex(6)

The viewport rects are the same, but the content size has been scaled. This results in a clip region for the content frame being twice the size it should be.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

For reference here's a try push from bug 1558106 showing the failure: https://treeherder.mozilla.org/#/jobs?repo=try&searchStr=linux%2Cx64%2Cquantumrender%2Copt%2Creftests%2Ctest-linux64-qr%2Fopt-reftest-e10s-5%2Cr%28r5%29&revision=241386990716cd1f73c790229c380a61361f03c8

Comment 2

[BugBot [:suhaib / :marco]]

The priority flag is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Looks like this test magically fixed itself: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=1b872f7b59afca88b5663c7070011d6d1d9f6f56

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1558933 - Re-enable reftest that is now passing again. r?gw

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b2f4c8ae362
Re-enable reftest that is now passing again. r=gw

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2b2f4c8ae362

Comment 7

[Botond Ballo [:botond]]

Might be interesting to know what fixed this.