1558940 - Worker requires should support relative paths

Status: RESOLVED FIXED

(Toolkit :: General, task, P5)

Description

[Jason Laster [:jlast]]

Currently, worker requires support absolute resource paths

importScripts("resource://gre/modules/workers/require.js");
const { createTask } = require("resource://devtools/shared/worker/helper.js");

It would be great if we could add a builder pattern similar to DevTools Browser loader that lets us specify a baseUri.

const { require } = BrowserLoader({
    baseURI: "resource://devtools/client/debugger",
    window
});
require('./src/main') ;

This is particularly useful now because the Debugger's workers are currently using commonjs requires and are being bundled via webpack source-map.js

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

We're moving to ES6 modules, and away from require, so this issue seems obsolete.

Comment 3

[Alexandre Poirot [:ochameau]]

Actually, this would be trivial to implement and would help me land an incremental steps toward ES6 modules in devtools.

In the debugger, we are currently using webpack to craft bundles as it is too complex to use commonjs in workers because of this limitation.
Using commonjs (like all other code in devtools) instead of webpack bundles is actually going to help move all devtools codebase from commonjs to ESM.

So I'm willing to add this feature. It will also help wait for ESM support in workers. We can keep using commonjs until this is implemented.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1558940 - [devtools] Support relative require path in worker commonjs loader.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1410df016b8
[devtools] Support relative require path in worker commonjs loader. r=arai

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a1410df016b8