Closed Bug 1558980 Opened 5 years ago Closed 5 years ago

Convert all XUL plain mochitests to chrome mochitests

Categories

(Testing :: Mochitest, task)

Version 3
task
Not set
normal

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: bdahl, Assigned: bdahl)

References

Details

Attachments

(1 file, 1 obsolete file)

Similar to bug 1557371:

Two benefits:

  1. Align test setup with shipping Firefox - We don't allow content privilege XUL in shipping versions of Firefox, so having the tests be chrome would be more realistic to our use case.

  2. Support the XUL to XHTML migration. These files will soon become XHTML files, but will still need to load XUL elements, so they'll need to be marked as chrome privileged to continue working.

Summary: Load all XUL plain mochitests as chrome mochitests → Convert all XUL plain mochitests to chrome mochitests

Two benefits:

  1. Align test setup with shipping Firefox - We don't allow content
    privilege XUL in shipping versions of Firefox, so having the tests be
    chrome would be more realistic to our use case.

  2. Support the XUL to XHTML migration. These files will soon become XHTML
    files, but will still need to load XUL elements, so they'll need to be
    marked as chrome privileged to continue working.

Two benefits:

  1. Align test setup with shipping Firefox - We don't allow content
    privilege XUL in shipping versions of Firefox, so having the tests be
    chrome would be more realistic to our use case.

  2. Support the XUL to XHTML migration. These files will soon become XHTML
    files, but will still need to load XUL elements, so they'll need to be
    marked as chrome privileged to continue working.

I had a few failures that I thought were from another patch, but it was actually this patch causing the issue:

  1. test_focusrings.xul - was using innerHTML which was being sanitized now that it's run in chrome, I've changed it to use a doc fragment instead.
  2. test_bug486990.xul - relied on content priv behavior of disabling/enabling context menus. I've converted the text to XHTML and left it as a plain mochitest. Eventually we'll need to update this test if we turn off all XUL in content priv, but I'd like to punt on that for now.
  3. test_bug465448.xul - missed some path updates
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a0ba8a3de05
Convert all XUL mochitest plain tests to chrome. r=mossop
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/006079193c25
Backed out changeset 7a0ba8a3de05 for mochitest-chrome failures. CLOSED TREE
Attachment #9071742 - Attachment is obsolete: true
Flags: needinfo?(bdahl)
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e17ee766fc37
Convert all XUL mochitest plain tests to chrome. r=mossop

Looks like my second push to phabricator didn't update my initial phabricator review and I pushed the wrong one.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: