1558980 - Convert all XUL plain mochitests to chrome mochitests

Status: RESOLVED FIXED

(Testing :: Mochitest, task)

Description

[Brendan Dahl [:bdahl]]

Similar to bug 1557371:

Two benefits:

1. Align test setup with shipping Firefox - We don't allow content privilege XUL in shipping versions of Firefox, so having the tests be chrome would be more realistic to our use case.

2. Support the XUL to XHTML migration. These files will soon become XHTML files, but will still need to load XUL elements, so they'll need to be marked as chrome privileged to continue working.

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: Bug 1558980 - Convert all XUL mochitest plain tests to chrome. r=mossop

Two benefits:

1. Align test setup with shipping Firefox - We don't allow content
   privilege XUL in shipping versions of Firefox, so having the tests be
   chrome would be more realistic to our use case.

2. Support the XUL to XHTML migration. These files will soon become XHTML
   files, but will still need to load XUL elements, so they'll need to be
   marked as chrome privileged to continue working.

Comment 2

[Brendan Dahl [:bdahl]]

Attachment: Bug 1558980 - Convert all XUL mochitest plain tests to chrome. r=mossop

Two benefits:

1. Align test setup with shipping Firefox - We don't allow content
   privilege XUL in shipping versions of Firefox, so having the tests be
   chrome would be more realistic to our use case.

2. Support the XUL to XHTML migration. These files will soon become XHTML
   files, but will still need to load XUL elements, so they'll need to be
   marked as chrome privileged to continue working.

Comment 3

[Brendan Dahl [:bdahl]]

I had a few failures that I thought were from another patch, but it was actually this patch causing the issue:

1. test_focusrings.xul - was using innerHTML which was being sanitized now that it's run in chrome, I've changed it to use a doc fragment instead.
2. test_bug486990.xul - relied on content priv behavior of disabling/enabling context menus. I've converted the text to XHTML and left it as a plain mochitest. Eventually we'll need to update this test if we turn off all XUL in content priv, but I'd like to punt on that for now.
3. test_bug465448.xul - missed some path updates

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a0ba8a3de05
Convert all XUL mochitest plain tests to chrome. r=mossop

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/006079193c25
Backed out changeset 7a0ba8a3de05 for mochitest-chrome failures. CLOSED TREE

Comment 6

[Alexandru Michis [:malexandru]]

Backed out changeset 7a0ba8a3de05 for mochitest-chrome failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/006079193c25dd1626f148fb54372e7f451068dc

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=7a0ba8a3de0562b4a39038007eef55d30f2952d5&selectedJob=253643037

Failure log:

• In test_focusrings: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253640451&repo=autoland&lineNumber=12291

• In test_bug465448.xul: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253640440&repo=autoland&lineNumber=2526

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e17ee766fc37
Convert all XUL mochitest plain tests to chrome. r=mossop

Comment 8

[Brendan Dahl [:bdahl]]

Looks like my second push to phabricator didn't update my initial phabricator review and I pushed the wrong one.

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e17ee766fc37