1559168 - `mach browsertime --setup` needs to set +x on installed binaries

Status: VERIFIED DUPLICATE of bug 1559727

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

We have reports of folks not being able to execute ffmpeg, convert, compare, etc, especially on macOS. It looks like we need to set +x ourselves; either the archives don't contain the bit, or it's being dropped by the unpacking flow.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Bug 1559168: 'mach browsertime --setup' needs to set +x on installed binaries. r?nalexander

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Bug 1559168: 'mach browsertime --setup' needs to set +x on installed binaries. r?nalexander

Depends on D43114

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Bug 1559168: 'mach browsertime --setup' needs to set +x on installed binaries. r?nalexander

Depends on D43114

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Bug 1559168: 'mach browsertime --setup' needs to set +x on installed binaries. r?nalexander

Depends on D43146

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Bug 1559168: 'mach browsertime --setup' needs to set +x on installed binaries. r?nalexander

Depends on D43151

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry (again) for all the Phabricator ticket creations, and accompanying spam; this should be ready for testing and review (in that order), over in https://phabricator.services.mozilla.com/D43152.

Nick, feel free to assign this to me, so the email spam can largely be mine :-)

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Bug 1559168: 'mach browsertime --setup' needs to set +x on installed binaries. r?nalexander

Depends on D43152

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Bug 1559168: 'mach browsertime --setup' needs to set +x on installed binaries. r?nalexander

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm happy to report that :sparky has a fix for this and other issues over in bug 1559727. I haven't been actively working on this for a while (sorry!) Greg, did you want to take this, or should we just mark it as a duplicate (since it ultimately is?)

Comment 10

[Greg Mierzwinski [:sparky]]

Yup, let's resolve it as a duplicate.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx; verified.