1559243 - [AS only] After disabling Pocket section in via about:prefererences, Pocket section can't be re-enabled until restart

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Kate Hudson :k88hudson]

With discovery stream disabled:

1. Go to about:preferences#home and disable the Pocket section
2. Verify Pocket is gone from the new tab page
3. Re-enable pocket on about:preferences#home

Actual: Pocket is still missing from the new tab page until a restart
Expected: Pocket is visible on the new tab page

This regression was introduced somewhere in Firefox 68.

Comment 1

[Ed Lee :Mardak]

Reverting bug 1544578 fixes the problem. This only affects de locale 68 beta users right now

Comment 2

[Ed Lee :Mardak]

German users won't be able to turn pocket back on until restart

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5116

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/0dff9f803849

Comment 5

[Ed Lee :Mardak]

Attachment: Bug 1559243 - [AS only] After disabling Pocket section in via about:prefererences, Pocket section can't be re-enabled until restart

Comment 6

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

The issue is no longer reproducible on the latest Nightly 69.0a1 (Build ID 20190619095537) on Windows 10, macOS 10.14, and Arch Linux 4.14.3.

Comment 7

[Ed Lee :Mardak]

Comment on attachment 9072749 [details]
Bug 1559243 - [AS only] After disabling Pocket section in via about:prefererences, Pocket section can't be re-enabled until restart

Beta/Release Uplift Approval Request

• User impact if declined: German users turning off pocket new tab section won't see it turn back on until restarting firefox
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Restores existing behavior by partially reverting the regressing bug 1544578
• String changes made/needed: none

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9072749 [details]
Bug 1559243 - [AS only] After disabling Pocket section in via about:prefererences, Pocket section can't be re-enabled until restart

AS fix for 68.0b12

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/07204fabaf18