Closed Bug 1559261 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17327 - Have containValues check array lengths

Categories

(Core :: Web Audio, defect, P4)

Product:
Core
Component:
Web Audio
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17327 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17327
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Have containValues check array lengths

If the number of distinct elements in the input array does not match
the number of elements in the expected set, an error was thrown trying
to read a property from undefined.

Instead, check that the lengths match and if they don't fail the test
with an appropriate message.

Bug: 974022
Test: audit-failures.html
Change-Id: Ifa2da978f3c0f67dc444c69ceddb862675908b05
Reviewed-on: https://chromium-review.googlesource.com/1659492
WPT-Export-Revision: d315d7e69f92c77b5ce696ddd668aade391b5498

Component: web-platform-tests → Web Audio
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 168 tests and 4177[android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt], 4169[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt] subtests OK : 128[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt], 129[android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt] PASS : 3938[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt], 3939[android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt] FAIL : 238[android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt], 231[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt] TIMEOUT: 1 ERROR : 36[android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt], 37[linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt] Tests that are disabled for instability: /webaudio/the-audio-api/the-audiobuffersourcenode-interface/sub-sample-buffer-stitching.html: [linux32-shippable-opt,linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,linux64-shippable-opt,linux64-shippable-qr-opt] /webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/no-cors.https.html: [android-em-7.0-x86_64-debug,android-em-7.0-x86_64-opt] /webaudio/the-audio-api/the-scriptprocessornode-interface/simple-input-output.html
The following tests were disabled based on stability try push: webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/09a58dd85306 [wpt PR 17327] - Have containValues check array lengths, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/e489cb7e40f6 [wpt PR 17327] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/09a58dd85306
https://hg.mozilla.org/mozilla-central/rev/e489cb7e40f6

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.