Closed Bug 1559322 Opened 5 years ago Closed 5 years ago

SSL tests no longer run locally on Windows

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- fixed

People

(Reporter: emk, Assigned: emk)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1559322 - Use "GreD" and "GreBinD" instead of "CurProcD" to remove macOS-specific hack and influence from firefox-appdir. r?keeler
47 bytes, text/x-phabricator-request
Details | Review

Log:

$ ./mach build && ./mach xpcshell-test security/manager/ssl/tests/unit/test_cert_overrides.js
 f:/m/mozilla-unified/obj-x86_64-pc-mingw32/backend.RecursiveMakeBackend is out of date with respect to f:/m/mozilla-unified/security/manager/ssl/tests/unit/xpcshell.ini
Build configuration changed. Regenerating backend.
 0:02.44 f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_virtualenvs/init/Scripts/python.exe f:/m/mozilla-unified/obj-x86_64-pc-mingw32/config.status
Reticulating splines...
 0:01.17 File already read. Skipping: f:/m/mozilla-unified/modules/brotli/moz.build
 0:08.01 File already read. Skipping: f:/m/mozilla-unified/gfx/angle/targets/angle_common/moz.build
 0:08.13 File already read. Skipping: f:/m/mozilla-unified/gfx/angle/targets/angle_common/moz.build
 0:08.14 File already read. Skipping: f:/m/mozilla-unified/gfx/angle/targets/angle_common/moz.build
 0:08.15 File already read. Skipping: f:/m/mozilla-unified/gfx/angle/targets/angle_common/moz.build
 0:08.15 File already read. Skipping: f:/m/mozilla-unified/gfx/angle/targets/translator/moz.build
 0:08.15 File already read. Skipping: f:/m/mozilla-unified/gfx/angle/targets/libGLESv2/moz.build
Finished reading 2155 moz.build files in 15.70s
Read 66 gyp files in parallel contributing 0.00s to total wall time
Processed into 11041 build config descriptors in 11.71s
RecursiveMake backend executed in 13.94s
  3831 total backend files; 0 created; 2 updated; 3829 unchanged; 0 deleted; 44 -> 1419 Makefile
FasterMake backend executed in 0.54s
  13 total backend files; 0 created; 1 updated; 12 unchanged; 0 deleted
VisualStudio backend executed in 10.07s
Generated Visual Studio solution at f:/m/mozilla-unified/obj-x86_64-pc-mingw32\msvc\mozilla.sln
Total wall time: 55.04s; CPU time: 55.04s; Efficiency: 100%; Untracked: 3.08s
 0:58.46 Clobber not needed.
 0:58.46 Adding make options from f:\m\mozilla-unified\.mozconfig
    AUTOCLOBBER=1
    MOZ_OBJDIR=f:/m/mozilla-unified/obj-x86_64-pc-mingw32
    OBJDIR=f:/m/mozilla-unified/obj-x86_64-pc-mingw32
    FOUND_MOZCONFIG=f:/m/mozilla-unified/.mozconfig
    export FOUND_MOZCONFIG
 0:58.54 d:\mozilla-build\bin\mozmake.EXE -f client.mk -s
 1:00.93 Elapsed: 0.01s; From dist/public: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 1:00.95 Elapsed: 0.01s; From dist/private: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 1:01.08 Elapsed: 0.10s; From dist/xpi-stage: Kept 96 existing; Added/updated 0; Removed 0 files and 0 directories.
 1:02.40 Elapsed: 1.41s; From _tests: Kept 0 existing; Added/updated 1158; Removed 0 files and 0 directories.
 1:03.24 Elapsed: 2.23s; From dist/bin: Kept 0 existing; Added/updated 2755; Removed 1 files and 0 directories.
 1:04.94 Elapsed: 4.06s; From dist/include: Kept 0 existing; Added/updated 5852; Removed 0 files and 0 directories.
 1:05.02 ./buildid.h.stub
 1:05.48 ./source-repo.h.stub
 1:07.99 build/application.ini.stub
 1:09.07 build/application.ini.h.stub
 1:10.05 build/clang-plugin/tests
 1:12.04 js/src/rust/force-cargo-library-build
 1:12.04 toolkit/library/rust/force-cargo-library-build
 1:12.05 js/src/frontend/binast/force-cargo-host-program-build
 1:12.06 testing/geckodriver/force-cargo-program-build
 1:16.77     Blocking waiting for file lock on build directory
 1:17.35     Finished release [optimized] target(s) in 5.26s
 1:19.09     Finished release [optimized] target(s) in 6.99s
 1:28.34     Finished release [optimized] target(s) in 16.24s
 1:29.85     Finished release [optimized] target(s) in 17.74s
 1:47.45 browser/app
 1:50.29 browser/app/firefox.exe
 1:50.60 Embedding manifest from ../../../browser/app/firefox.exe.manifest
 1:56.08 toolkit/mozapps/extensions/built_in_addons.json.stub
 2:40.43 Processing config: d:\mozilla-build\nsis-3.01\nsisconf.nsh
 2:40.43 Processing script file: "uninstaller.nsi" (ACP)
 2:42.04 Processed 1 file, writing output (x86-unicode):
 2:42.04 warning: install function "WriteRegQWORD" not referenced - zeroing code (0-27) out
 2:42.04 warning: install function "ReadRegQWORD" not referenced - zeroing code (27-50) out
 2:42.04 warning: Variable "AddTaskbarSC" not referenced or never set, wasting memory!
 2:42.04 Output: "f:\m\mozilla-unified\obj-x86_64-pc-mingw32\browser\installer\windows\instgen\helper.exe"
 2:42.05 Install: 1 page (64 bytes), 1 section (2072 bytes), 5898 instructions (165144 bytes), 2718 strings (20378 bytes), 1 language table (230 bytes).
 2:42.05 Uninstall: 4 pages (320 bytes), 1 section (2072 bytes), 3054 instructions (85512 bytes), 2262 strings (17410 bytes), 1 language table (310 bytes).
 2:42.06 Using zlib compression.
 2:42.06 EXE header size:               63488 / 38912 bytes
 2:42.06 Install code:                 188332 / 188328 bytes
 2:42.06 Install data:                 184588 / 184596 bytes
 2:42.06 Uninstall code+data:          487035 / 487027 bytes
 2:42.06 CRC (0x4ACCFFDC):                  4 / 4 bytes
 2:42.06 Total size:                   923447 / 898867 bytes (102.7%)
 2:42.12 3 warnings:
 2:42.12   install function "WriteRegQWORD" not referenced - zeroing code (0-27) out
 2:42.12   install function "ReadRegQWORD" not referenced - zeroing code (27-50) out
 2:42.12   Variable "AddTaskbarSC" not referenced or never set, wasting memory!
 2:44.43 Processing config: d:\mozilla-build\nsis-3.01\nsisconf.nsh
 2:44.43 Processing script file: "maintenanceservice_installer.nsi" (ACP)
 2:44.76 Processed 1 file, writing output (x86-unicode):
 2:44.76 warning: install function "WriteRegQWORD" not referenced - zeroing code (0-27) out
 2:44.76 warning: install function "ReadRegQWORD" not referenced - zeroing code (27-50) out
 2:44.76 Output: "f:\m\mozilla-unified\obj-x86_64-pc-mingw32\browser\installer\windows\instgen\maintenanceservice_installer.exe"
 2:44.77 Install: 1 page (64 bytes), 1 section (2072 bytes), 642 instructions (17976 bytes), 752 strings (4850 bytes), 1 language table (210 bytes).
 2:44.77 Uninstall: 2 pages (192 bytes), 1 section (2072 bytes), 216 instructions (6048 bytes), 752 strings (6218 bytes), 1 language table (250 bytes).
 2:44.77 Using zlib compression.
 2:44.78 EXE header size:               64000 / 38912 bytes
 2:44.78 Install code:                  25616 / 25612 bytes
 2:44.78 Install data:                  11780 / 11788 bytes
 2:44.78 Uninstall code+data:           52232 / 52224 bytes
 2:44.78 CRC (0x8A186F5C):                  4 / 4 bytes
 2:44.78 Total size:                   153632 / 128540 bytes (119.5%)
 2:44.81 2 warnings:
 2:44.81   install function "WriteRegQWORD" not referenced - zeroing code (0-27) out
 2:44.81   install function "ReadRegQWORD" not referenced - zeroing code (27-50) out
 3:05.19 Packaging specialpowers@mozilla.org.xpi...
 3:05.93 Packaging quitter@mozilla.org.xpi...
 3:06.54 Packaging mozscreenshots@mozilla.org.xpi...
 3:07.10 470 compiler warnings present.
 3:07.34 Overall system resources - Wall time: 185s; CPU: 30%; Read bytes: 1661313536; Write bytes: 1423969280; Read time: 119; Write time: 46
To view resource usage of the build, run |mach resource-usage|.
 3:07.46 Your build was successful!
To take your build for a test drive, run: |mach run|
For more information on what to do now, see https://developer.mozilla.org/docs/Developer_Guide/So_You_Just_Built_Firefox
 0:00.92 INFO Found node at c:\Users\kimu\.mozbuild\node\node.exe
 0:00.92 INFO Found moz-http2 at f:\m\mozilla-unified\testing\xpcshell\moz-http2\moz-http2.js
 0:01.65 INFO Running tests sequentially.
 0:01.65 SUITE_START: xpcshell - running 1 tests
 0:01.66 INFO profile dir is c:\users\kimu\appdata\local\temp\firefox\xpcshellprofile
 0:01.92 TEST_START: security/manager/ssl/tests/unit/test_cert_overrides.js
 0:01.92 INFO security/manager/ssl/tests/unit/test_cert_overrides.js | full command: ['f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\dist\\bin\\xpcshell.exe', '-g', 'f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\dist\\bin', '-a', 'f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\dist\\bin\\browser', '-r', 'f:/m/mozilla-unified/obj-x86_64-pc-mingw32/dist/bin/components/httpd.manifest', '-m', '-s', '-e', 'const _HEAD_JS_PATH = "f:/m/mozilla-unified/testing/xpcshell/head.js";', '-e', 'const _MOZINFO_JS_PATH = "c:\\\\users\\\\kimu\\\\appdata\\\\local\\\\temp\\\\firefox\\\\xpcshellprofile\\\\mozinfo.json";', '-e', 'const _PREFS_FILE = "f:\\\\m\\\\mozilla-unified\\\\obj-x86_64-pc-mingw32\\\\temp\\\\user.js";', '-e', 'const _TESTING_MODULES_DIR = "f:\\\\m\\\\mozilla-unified\\\\obj-x86_64-pc-mingw32\\\\_tests\\\\modules\\\\";', '-f', 'f:\\m\\mozilla-unified\\testing\\xpcshell\\head.js', '-p', 'f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\temp\\xpc-plugins-cxfutv', '-e', 'const _HEAD_FILES = ["f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/head_psm.js"];', '-e', 'const _JSDEBUGGER_PORT = 0;', '-e', 'const _TEST_FILE = ["f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/test_cert_overrides.js"];', '-e', 'const _TEST_NAME = "security/manager/ssl/tests/unit/test_cert_overrides.js";', '-e', '_execute_test(); quit(0);']
 0:01.92 INFO security/manager/ssl/tests/unit/test_cert_overrides.js | current directory: 'f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\_tests\\xpcshell\\security\\manager\\ssl\\tests\\unit'
 0:01.92 INFO security/manager/ssl/tests/unit/test_cert_overrides.js | environment: ['XPCOM_DEBUG_BREAK=stack-and-abort', 'MOZHTTP2_PROXY_PORT=54304', 'MOZ_CRASHREPORTER=1', 'PATH=d:\\ProgramData\\Programs\\Git\\cmd;c:\\Users\\kimu\\bin;D:\\mozilla-build\\msys\\local\\bin;d:\\mozilla-build\\bin;d:\\mozilla-build\\kdiff3;d:\\mozilla-build\\node-v8.11.1-win-x64;d:\\mozilla-build\\nsis-3.01;d:\\mozilla-build\\python;d:\\mozilla-build\\python\\Scripts;d:\\mozilla-build\\python3;d:\\mozilla-build\\python3\\Scripts;.;D:\\mozilla-build\\msys\\local\\bin;D:\\mozilla-build\\msys\\mingw\\bin;D:\\mozilla-build\\msys\\bin;c:\\WINDOWS\\System32;c:\\WINDOWS;c:\\WINDOWS\\System32\\Wbem;d:\\PHP;d:\\kimu\\phabricator\\arcanist\\bin;d:\\kimu\\phabricator;d:\\Program Files\\Java\\jdk1.8.0_131\\bin;f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\dist\\bin', 'XPCSHELL_TEST_TEMP_DIR=f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\temp\\xpc-other-ar6hvj', 'MOZHTTP2_PORT=54303', 'MOZ_DISABLE_CONTENT_SANDBOX=1', 'MOZ_DISABLE_NONLOCAL_CONNECTIONS=1', 'MOZ_DEVELOPER_REPO_DIR=f:/m/mozilla-unified', 'MOZ_CRASHREPORTER_NO_REPORT=1', 'XPCSHELL_TEST_PROFILE_DIR=c:\\users\\kimu\\appdata\\local\\temp\\firefox\\xpcshellprofile']
 0:01.92 INFO security/manager/ssl/tests/unit/test_cert_overrides.js | as shell command: (cd 'f:\m\mozilla-unified\obj-x86_64-pc-mingw32\_tests\xpcshell\security\manager\ssl\tests\unit'; XPCOM_DEBUG_BREAK=stack-and-abort MOZHTTP2_PROXY_PORT=54304 MOZ_CRASHREPORTER=1 'PATH=d:\ProgramData\Programs\Git\cmd;c:\Users\kimu\bin;D:\mozilla-build\msys\local\bin;d:\mozilla-build\bin;d:\mozilla-build\kdiff3;d:\mozilla-build\node-v8.11.1-win-x64;d:\mozilla-build\nsis-3.01;d:\mozilla-build\python;d:\mozilla-build\python\Scripts;d:\mozilla-build\python3;d:\mozilla-build\python3\Scripts;.;D:\mozilla-build\msys\local\bin;D:\mozilla-build\msys\mingw\bin;D:\mozilla-build\msys\bin;c:\WINDOWS\System32;c:\WINDOWS;c:\WINDOWS\System32\Wbem;d:\PHP;d:\kimu\phabricator\arcanist\bin;d:\kimu\phabricator;d:\Program Files\Java\jdk1.8.0_131\bin;f:\m\mozilla-unified\obj-x86_64-pc-mingw32\dist\bin' 'XPCSHELL_TEST_TEMP_DIR=f:\m\mozilla-unified\obj-x86_64-pc-mingw32\temp\xpc-other-ar6hvj' MOZHTTP2_PORT=54303 MOZ_DISABLE_CONTENT_SANDBOX=1 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 MOZ_DEVELOPER_REPO_DIR=f:/m/mozilla-unified MOZ_CRASHREPORTER_NO_REPORT=1 'XPCSHELL_TEST_PROFILE_DIR=c:\users\kimu\appdata\local\temp\firefox\xpcshellprofile' 'f:\m\mozilla-unified\obj-x86_64-pc-mingw32\dist\bin\xpcshell.exe' -g 'f:\m\mozilla-unified\obj-x86_64-pc-mingw32\dist\bin' -a 'f:\m\mozilla-unified\obj-x86_64-pc-mingw32\dist\bin\browser' -r f:/m/mozilla-unified/obj-x86_64-pc-mingw32/dist/bin/components/httpd.manifest -m -s -e 'const _HEAD_JS_PATH = "f:/m/mozilla-unified/testing/xpcshell/head.js";' -e 'const _MOZINFO_JS_PATH = "c:\\users\\kimu\\appdata\\local\\temp\\firefox\\xpcshellprofile\\mozinfo.json";' -e 'const _PREFS_FILE = "f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\temp\\user.js";' -e 'const _TESTING_MODULES_DIR = "f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\_tests\\modules\\";' -f 'f:\m\mozilla-unified\testing\xpcshell\head.js' -p 'f:\m\mozilla-unified\obj-x86_64-pc-mingw32\temp\xpc-plugins-cxfutv' -e 'const _HEAD_FILES = ["f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/head_psm.js"];' -e 'const _JSDEBUGGER_PORT = 0;' -e 'const _TEST_FILE = ["f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/test_cert_overrides.js"];' -e 'const _TEST_NAME = "security/manager/ssl/tests/unit/test_cert_overrides.js";' -e '_execute_test(); quit(0);')
 0:02.27 pid:2112 Full command: ['f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\dist\\bin\\xpcshell.exe', '-g', 'f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\dist\\bin', '-a', 'f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\dist\\bin\\browser', '-r', 'f:/m/mozilla-unified/obj-x86_64-pc-mingw32/dist/bin/components/httpd.manifest', '-m', '-s', '-e', 'const _HEAD_JS_PATH = "f:/m/mozilla-unified/testing/xpcshell/head.js";', '-e', 'const _MOZINFO_JS_PATH = "c:\\\\users\\\\kimu\\\\appdata\\\\local\\\\temp\\\\firefox\\\\xpcshellprofile\\\\mozinfo.json";', '-e', 'const _PREFS_FILE = "f:\\\\m\\\\mozilla-unified\\\\obj-x86_64-pc-mingw32\\\\temp\\\\user.js";', '-e', 'const _TESTING_MODULES_DIR = "f:\\\\m\\\\mozilla-unified\\\\obj-x86_64-pc-mingw32\\\\_tests\\\\modules\\\\";', '-f', 'f:\\m\\mozilla-unified\\testing\\xpcshell\\head.js', '-p', 'f:\\m\\mozilla-unified\\obj-x86_64-pc-mingw32\\temp\\xpc-plugins-cxfutv', '-e', 'const _HEAD_FILES = ["f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/head_psm.js"];', '-e', 'const _JSDEBUGGER_PORT = 0;', '-e', 'const _TEST_FILE = ["f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/test_cert_overrides.js"];', '-e', 'const _TEST_NAME = "security/manager/ssl/tests/unit/test_cert_overrides.js";', '-e', '_execute_test(); quit(0);']
pid:2112 Unable to load \\untrusted-startup-test-dll.dll; LoadLibraryW failed: 126
 0:02.27 INFO (xpcshell/head.js) | test MAIN run_test pending (1)
 0:02.27 PASS run_port_equivalency_test - [run_port_equivalency_test : 75] The two specified ports must be -1 and 443 (in any order) - true == true
 0:02.39 PASS run_port_equivalency_test - [run_port_equivalency_test : 86] override set on port -1 should match port 443 - true == true
 0:02.39 PASS run_port_equivalency_test - [run_port_equivalency_test : 90] input override bits should match output bits - 1 == 1
 0:02.39 PASS run_port_equivalency_test - [run_port_equivalency_test : 92] input override temporary value should match output temporary value - true == true
 0:02.39 PASS run_port_equivalency_test - [run_port_equivalency_test : 94] override set on port -1 should not match port 563 - true == true
 0:02.39 PASS run_port_equivalency_test - [run_port_equivalency_test : 98] override cleared on port -1 should match port 443 - true == true
 0:02.39 PASS run_port_equivalency_test - [run_port_equivalency_test : 101] should have no bits set if there is no override - 0 == 0
 0:02.39 PASS run_port_equivalency_test - [run_port_equivalency_test : 75] The two specified ports must be -1 and 443 (in any order) - true == true
 0:02.40 PASS run_port_equivalency_test - [run_port_equivalency_test : 86] override set on port 443 should match port -1 - true == true
 0:02.40 PASS run_port_equivalency_test - [run_port_equivalency_test : 90] input override bits should match output bits - 1 == 1
 0:02.40 PASS run_port_equivalency_test - [run_port_equivalency_test : 92] input override temporary value should match output temporary value - true == true
 0:02.40 PASS run_port_equivalency_test - [run_port_equivalency_test : 94] override set on port 443 should not match port 563 - true == true
 0:02.40 PASS run_port_equivalency_test - [run_port_equivalency_test : 98] override cleared on port 443 should match port -1 - true == true
 0:02.40 PASS run_port_equivalency_test - [run_port_equivalency_test : 101] should have no bits set if there is no override - 0 == 0
 0:02.41 INFO (xpcshell/head.js) | test run_next_test 0 pending (2)
 0:02.41 INFO (xpcshell/head.js) | test MAIN run_test finished (2)
 0:02.41 INFO running event loop
 0:02.41 INFO security/manager/ssl/tests/unit/test_cert_overrides.js | Starting
 0:02.41 INFO (xpcshell/head.js) | test pending (2)
 0:02.50 ERROR NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.initWithPath]
_getBinaryUtil@f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/head_psm.js:527:13
_setupTLSServerTest@f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/head_psm.js:568:19
add_tls_server_setup/<@f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/head_psm.js:378:5
_run_next_test@f:\m\mozilla-unified\testing\xpcshell\head.js:1455:11
run@f:\m\mozilla-unified\testing\xpcshell\head.js:688:9
_do_main@f:\m\mozilla-unified\testing\xpcshell\head.js:227:6
_execute_test@f:\m\mozilla-unified\testing\xpcshell\head.js:529:5
@-e:1:1

 0:02.50 INFO exiting test
 0:02.50 INFO (xpcshell/head.js) | test run_next_test 0 finished (2)
 0:02.57 pid:2112 JavaScript strict warning: resource://testing-common/httpd.js, line 737: ReferenceError: reference to undefined property "_stopCallback"
 0:02.57 pid:2112 !!! error running onStopped callback: TypeError: callback is not a function
 0:02.57 pid:2112 !!! error running onStopped callback: TypeError: callback is not a function
 0:02.57 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "_stopCallback"" {file: "resource://testing-common/httpd.js" line: 737}]"
 0:02.62 TEST_END: Test FAIL, expected PASS. Subtests passed 14/14. Unexpected 0 - xpcshell return code: 0
 0:02.64 INFO INFO | Result summary:
 0:02.65 INFO INFO | Passed: 0
 0:02.65 INFO INFO | Failed: 1
 0:02.65 INFO INFO | Todo: 0
 0:02.65 INFO INFO | Retried: 0
 0:02.65 SUITE_END

xpcshell
~~~~~~~~
Ran 15 checks (14 subtests, 1 tests)
Expected results: 14
Unexpected results: 1
  test: 1 (1 fail)

Unexpected Results
------------------
security/manager/ssl/tests/unit/test_cert_overrides.js
  FAIL security/manager/ssl/tests/unit/test_cert_overrides.js - xpcshell return code: 0
 0:02.65 INFO Node moz-http2 server shutting down ...
 0:02.65 INFO Process stderr
 0:02.65 INFO (node:12724) ExperimentalWarning: The http2 module is an experimental API.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a65d8c098c9a378026173cd894c3059c025f7c58&tochange=505411a0364c91c191da0197f8a8c4c563732677

Flags: needinfo?(mathieu)

What's the error with the binary?

ERROR NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.initWithPath]
_getBinaryUtil@f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/head_psm.js:527:13

in _setupTLSServerTest() ?

As you can see the changeset you pointed out does not change anything that appears to be related to that... is this test the only one that fails?

Flags: needinfo?(mathieu)

(In reply to Mathieu Leplatre [:leplatrem] from comment #1)

What's the error with the binary?

ERROR NS_ERROR_FILE_UNRECOGNIZED_PATH: Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.initWithPath]
_getBinaryUtil@f:/m/mozilla-unified/obj-x86_64-pc-mingw32/_tests/xpcshell/security/manager/ssl/tests/unit/head_psm.js:527:13

in _setupTLSServerTest() ?

Yes. nsIFile does not accept "/data/local/xpcb/" as a valid path on Windows. Also if (!utilBin.exists()) { should not fail @head_psm.js:526.

As you can see the changeset you pointed out does not change anything that appears to be related to that... is this test the only one that fails?

I guess whatever tests using add_tls_server_setup will fail.

Yes. nsIFile does not accept "/data/local/xpcb/" as a valid path on Windows. Also if (!utilBin.exists()) { should not fail @head_psm.js:526.

The changeset you mentioned did not change those lines. Are you sure that the regression was introduced with my changes?

Looks like this line is the culprit:
https://hg.mozilla.org/integration/autoland/diff/505411a0364c91c191da0197f8a8c4c563732677/security/manager/ssl/tests/unit/xpcshell.ini#l1.7

+firefox-appdir = browser

With this change, the return value from Services.dirsvc.get("CurProcD", Ci.nsIFile); changes from ...\dist\bin to ...\dist\bin\browser, so _getBinaryUtil fails to find tls server binaries.

Oh, good catch!
...without this change, the resources that are packaged here are not found from the tests!

Attachment #9072136 - Attachment description: Bug 1559322 - Use "GreD" instead of "CurProcD" to remove influence from firefox-appdir. r?keeler → Bug 1559322 - Use "GreD" and "GreBinD" instead of "CurProcD" to remove macOS-specific hack and influence from firefox-appdir. r?keeler
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/9e8b490acc3b
Use "GreD" and "GreBinD" instead of "CurProcD" to remove macOS-specific hack and influence from firefox-appdir. r=keeler

https://hg.mozilla.org/mozilla-central/rev/9e8b490acc3b

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → VYV03354
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: