Code cleanup in about:logins

RESOLVED FIXED in Firefox 69

Status

()

task
P5
normal
RESOLVED FIXED
Last month
28 days ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

(Blocks 1 bug)

Trunk
mozilla69
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(6 attachments)

  • Add in a <form> and use form.reset() to reset form validation
  • Pull out a reference to classList in handleEvent functions
  • Add jsdoc to methods of custom elements
  • Move custom attributes to element.dataset
  • Make method naming style consistent (_prefix vs no _prefix)
  • Order methods consistently
Flags: qe-verify-
Assignee: nobody → jaws
Status: NEW → ASSIGNED

Attributes that are related to Fluent-based strings intentionally weren't moved to element.dataset.

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ceaec1476452
Add in a form element and use form.reset to clear form validation. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/e778be2565a3
Pull out a reference to classList in handleEvent. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/5ff49a14d8d3
Add jsdoc to public methods of custom elements. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c5293d04b409
Move custom attributes to element.dataset. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/3172f277e311
Cache references to shadow DOM elements and move the call to reflectFluentStrings to the super-class. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/ea256e43a657
Add underscore prefixes to private methods. r=Gijs
You need to log in before you can comment on or make changes to this bug.