1559355 - Code cleanup in about:logins

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P5)

Description

[Jared Wein [:jaws] (please needinfo? me)]

• Add in a <form> and use form.reset() to reset form validation
• Pull out a reference to classList in handleEvent functions
• Add jsdoc to methods of custom elements
• Move custom attributes to element.dataset
• Make method naming style consistent (_prefix vs no _prefix)
• Order methods consistently

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1559355 - Add in a form element and use form.reset to clear form validation. r?Gijs!

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1559355 - Pull out a reference to classList in handleEvent. r?Gijs!

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1559355 - Add jsdoc to public methods of custom elements. r?Gijs!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1559355 - Move custom attributes to element.dataset. r?Gijs!

Attributes that are related to Fluent-based strings intentionally weren't moved to element.dataset.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1559355 - Cache references to shadow DOM elements and move the call to reflectFluentStrings to the super-class. r?Gijs!

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1559355 - Add underscore prefixes to private methods. r?Gijs!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceaec1476452
Add in a form element and use form.reset to clear form validation. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/e778be2565a3
Pull out a reference to classList in handleEvent. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/5ff49a14d8d3
Add jsdoc to public methods of custom elements. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c5293d04b409
Move custom attributes to element.dataset. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/3172f277e311
Cache references to shadow DOM elements and move the call to reflectFluentStrings to the super-class. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/ea256e43a657
Add underscore prefixes to private methods. r=Gijs

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ceaec1476452
https://hg.mozilla.org/mozilla-central/rev/e778be2565a3
https://hg.mozilla.org/mozilla-central/rev/5ff49a14d8d3
https://hg.mozilla.org/mozilla-central/rev/c5293d04b409
https://hg.mozilla.org/mozilla-central/rev/3172f277e311
https://hg.mozilla.org/mozilla-central/rev/ea256e43a657