Closed Bug 1559407 Opened 1 year ago Closed 1 year ago

Compile error in nsNetscapeProfileMigratorBase::ReadBranch

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(seamonkey2.63 unaffected)

RESOLVED FIXED
seamonkey2.66
Tracking Status
seamonkey2.63 --- unaffected

People

(Reporter: frg, Assigned: frg)

References

(Regression)

Details

Attachments

(1 file)

There is a loop pref and a local pref. Old code so probably some change broke it but it is really bad code anyway and should be fixed in all supported trees.

0:25.53 d:/seamonkey/comm-central/comm/suite/components/profile/nsNetscapeProfileMigratorBase.cpp(532,23): error: redefinition of '
pref' with a different type: 'nsNetscapeProfileMigratorBase::PrefBranchStruct ' vs 'nsTString<char> &'
0:25.53 PrefBranchStruct
pref = new PrefBranchStruct;
0:25.53 ^
0:25.53 d:/seamonkey/comm-central/comm/suite/components/profile/nsNetscapeProfileMigratorBase.cpp(526,14): note: previous definitio
n is here
0:25.53 for (auto& pref : prefs) {
0:25.53 ^
0:25.70 1 error generated.
0:25.72 mozmake.EXE[4]: *** [d:/seamonkey/comm-central/config/rules.mk:812: nsNetscapeProfileMigratorBase.obj] Error 1
0:25.72 mozmake.EXE[3]: *** [d:/seamonkey/comm-central/config/recurse.mk:74: comm/suite/components/profile/target] Error 2
0:25.72 mozmake.EXE[3]: *** Waiting for unfinished jobs....

Patch from Bill with changes discussed on irc. IanN can you look it over and do a seprate a+ just in case.

Attachment #9072180 - Flags: review+
Attachment #9072180 - Flags: approval-comm-esr60?

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b26f81583564
Don't redefine pref variable. r=frg

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.66
Comment on attachment 9072180 [details] [diff] [review]
1559407-profile-migrator.patch

a=me for where needed
Attachment #9072180 - Flags: approval-comm-esr60? → approval-comm-esr60+

Just saw that it was a recent fix that broke it so no need to backport.

You need to log in before you can comment on or make changes to this bug.