1559412 - Support web app manifest ImageResource.purpose

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Tiger Oakes]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

A parsed web app manifest should include all properties for ImageResources in the icons field

Actual results:

"purpose" is stripped out from ImageResource entries

Expected results:

The ImageObjectProcessor class only keeps the "src", "type", and "sizes" attributes from entries in the "icons" array in a web app manifest. A-C needs access to the "purpose" field as well, which determines if an icon can be masked and used as an adaptive icon.

https://www.w3.org/TR/appmanifest/#purpose-member
https://searchfox.org/mozilla-central/source/dom/manifest/ImageObjectProcessor.jsm#69

Comment 1

[Chris Peterson [:cpeterson]]

Marcos, just a heads up, in case you have opinions: the A-C team would like to access ImageResource's purpose field for Fenix. Maliha is an intern working with the A-C team.

Comment 2

[Marcos Caceres [:marcosc]]

Thanks for the heads-up, Chris!

Maliha, happy to review or help however I can. I'm marcosc on Slack if you have any questions.

Comment 3

[Marcos Caceres [:marcosc]]

Attachment: Bug 1559412 - Support web app manifest ImageResource.purpose

implementation of purpose member

Comment 4

[Marcos Caceres [:marcosc]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8398e28426ab8fd6a4870e8965c13ccbb9ca33d9

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90d0473fe6aa
Support web app manifest ImageResource.purpose r=baku

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/90d0473fe6aa

Comment 7

[Chris Peterson [:cpeterson]]

firefox69=wontfix because we don't need to uplift this web app manifest changes to GV 69 Beta (especially considering it adds new dom.properties strings that need to be translated).