Closed Bug 1559431 Opened 5 years ago Closed 5 years ago

Add UI for Social Tracking

Categories

(Firefox :: Protections UI, enhancement, P1)

68 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox70 --- verified

People

(Reporter: ewright, Assigned: ewright)

References

(Blocks 1 open bug)

Details

(Whiteboard: [protection-report][triage][skyline][stp])

Attachments

(1 file)

Add social tracking blocking UI. This should show when user does not have strict ETP enabled.

The social tracking card has been removed. This bug is now about ensuring social blocking in showing up on the graph.

invision mock

Whiteboard: [protection-report] → [protection-report][triage]
Whiteboard: [protection-report][triage] → [protection-report][triage][skyline]
Assignee: nobody → ewright
Status: NEW → ASSIGNED

WIP until I can verify this with STP

Hi Erica,
We had a meeting today to discuss how to hide/show the UI for Social Tracking and also how to surface it in various UI components.

For the Protection Report, show the UI when privacy.socialtracking.block_cookies.enabled is set to true. Everything should be gated on this.

In order to populate the Social Tracker numbers, look for loads that have these nsIWebProgressListener flags (STATE_LOADED_SOCIALTRACKING_CONTENT && STATE_COOKIES_BLOCKED_TRACKER) || (STATE_BLOCKED_SOCIALTRACKING_CONTENT). The first case is for when a user is in Standard and is blocking cookies from social trackers. The second case is for when the user is in Strict and is blocking a social tracker from loading.

This is similar to how we need to handle Privacy Panel and Feature Promotion. See https://bugzilla.mozilla.org/show_bug.cgi?id=1571494.

I'm not sure if this is possible - but...

  • What if you get into a state where a load has STATE_BLOCKED_SOCIALTRACKING_CONTENT, but privacy.socialtracking.block_cookies.enabled is false? In this case, I think the Social Tracker block should be attributed to "TRACKERS_ID" in your patch.
  • What if you get into a state where a load has STATE_LOADED_SOCIALTRACKING_CONTENT && STATE_COOKIES_BLOCKED_TRACKER, but privacy.socialtracking.block_cookies.enabled is false? In this case, I think the Social Tracking load should be attributed to TRACKING_COOKIES_ID in your patch.

We should probably discuss this further.

Whiteboard: [protection-report][triage][skyline] → [protection-report][triage][skyline][stp]
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/feb862d3ba29
Add social tracking to the ETP graph r=johannh
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Regressions: 1573577
Flags: qe-verify+
Flags: needinfo?(ciprian.georgiu)

This is verified fixed on Beta 70.0b11 under macOS 10.13, Win 10 x64 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(ciprian.georgiu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: