Open Bug 1559485 Opened 5 years ago Updated 2 years ago

Use UniqueChars in RecordAllocationInfo

Categories

(Core :: Gecko Profiler, task, P2)

Product:
Core
Component:
Gecko Profiler
Version:
62 Branch
Type:
task

Tracking

()

People

(Reporter: gregtatum, Unassigned)

Details

From jimb in Bug 1545582

What you really want, though, is a fully-independent structure that you can stash in a marker. The best way to represent that would be to use UniqueChars and UniqueTwoByteChars here, so that the RecordAllocationInfo struct owns its text and frees it automatically. That will prevent C++ from generating implicit copy constructors and copy assignment, so you'll get static assurance that you're only moving values around, not making accidental copies. Please file a follow-up bug to make that change.

Assignee: nobody → gtatum
Priority: -- → P2
Type: defect → task
Assignee: gtatum → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.