Closed Bug 1559706 Opened 5 years ago Closed 5 years ago

text disappears when hovering over box-model values

Categories

(Core :: Web Painting, defect, P2)

69 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- disabled
firefox67 --- disabled
firefox68 --- disabled
firefox69 --- wontfix
firefox70 --- verified
firefox71 --- verified

People

(Reporter: alice0775, Assigned: mikokm)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(3 files, 2 obsolete files)

Steps to reproduce:

  1. Inspect any element
  2. Select layout tab
  3. Mouse hover over box-model values

Actual Results:
The value text disappears

Expected Results:
The value text should be highlighted

Attached video screencast

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0ca9a03071b76cb0aca81b83ed451dedd2b7c1f5&tochange=87409f291fa6a003f00ae782528bcd4734eeaee0

Regressed by: 87409f291fa6a003f00ae782528bcd4734eeaee0 Miko Mynttinen — Bug 1413546 - Enable retained display lists for parent process r=mattwoodrow

Miko Mynttinen,
Your patch seems to cause the regression. Can you please look into this?

Attached file about:support (obsolete) —
Has Regression Range: --- → yes
Has STR: --- → yes
Attached file about:support
Attachment #9072458 - Attachment is obsolete: true

Removing xulstore folder in user profile fixes the issue.
It seems to have damaged the profile for some reason.

Status: NEW → RESOLVED
Closed: 5 years ago
No longer regressed by: 1413546
Resolution: --- → WORKSFORME
Flags: needinfo?(mikokm)

Oops, I can reproduced with new profile...
The following step3-5 seems to depended on window size/fontsize/zoomlevel.

Steps to reproduce:
0. Start Nightly with new profile

  1. Inspect any element
  2. Select layout tab
  3. Undock Inspector i.e. Separate Window
  4. Maximized the Inspector window
  5. Zoom in 5 time in the inspector
  6. Mouse hover over box-model values

Actual Results:
The value text disappears

Expected Results:
The value text should be highlighted

Status: RESOLVED → REOPENED
Regressed by: 1413546
Resolution: WORKSFORME → ---
Status: REOPENED → NEW
Flags: needinfo?(mikokm)

Reproduces on mac too.

Component: Inspector: Layout → Web Painting
Product: DevTools → Core

With parent rdl pref force enabled this regressed by https://hg.mozilla.org/integration/autoland/rev/f00a5d27f41760febe43b3ef52b727a54f082abf in my bisection.

The call to BuildCompositorHitTestInfoIfNeeded changed in that patch is what causes it. Ie passing false for the last argument when the zindex is 0 makes the bug show up.

Blocks: 1534549
Flags: needinfo?(mikokm)
Regressed by: 1529458
No longer regressed by: 1413546

The priority flag is not set for this bug.
:mattwoodrow, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(matt.woodrow)
Flags: needinfo?(matt.woodrow)
Priority: -- → P2
Regressed by: 1413546

This doesn't need to be tracked for 69

miko, tnikkel, can one of you take another look at this issue? Maybe we have a chance to fix it for 71.

Flags: needinfo?(tnikkel)
Flags: needinfo?(mikokm)

(In reply to Liz Henry (:lizzard) from comment #12)

miko, tnikkel, can one of you take another look at this issue? Maybe we have a chance to fix it for 71.

The root cause for this issue is bug 1534549, which is non-trivial to fix. We could possibly disable the broken hit test info optimization for parent process RDL at the expense of perhaps 10% longer display list builds.

Another possibility might be to implement devtools side workaround by, for example, setting the parent element hit test flags different.

Flags: needinfo?(mikokm)

Miko covered it.

Flags: needinfo?(tnikkel)

Patrick, do you think someone on your team might look into a workaround?

Flags: needinfo?(pbrosset)

Miko, what do you mean by:

setting the parent element hit test flags different.

Could you explain in details how we might go about doing this in devtools?

Keeping the needinfo on me for now so that, when I know more, I can pass this on to someone to get fixed.

Flags: needinfo?(pbrosset) → needinfo?(mikokm)

By the way, I was able to reproduce on macOS with the steps in comment 6.

OS: Windows 10 → All
Hardware: x86_64 → All
Flags: needinfo?(pbrosset)

(In reply to Patrick Brosset <:pbro> from comment #16)

Miko, what do you mean by:

setting the parent element hit test flags different.

Could you explain in details how we might go about doing this in devtools?

Keeping the needinfo on me for now so that, when I know more, I can pass this on to someone to get fixed.

I think I managed to find a workaround. Setting a non-zero z-index for these elements causes them to become stacking contexts, which avoids the gecko bug with layerization.

Flags: needinfo?(mikokm)
Attached patch 1559706.patch (obsolete) — Splinter Review
Assignee: nobody → mikokm
Status: NEW → ASSIGNED

Thanks Miko for the reply and for sending a patch! I see it's been accepted, let's land it.

Flags: needinfo?(pbrosset)
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3da7c0dce263
Workaround for invalid layerization in Inspector r=gl
Status: ASSIGNED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(mikokm)

Comment on attachment 9092759 [details]
Bug 1559706 - Workaround for invalid layerization in Inspector r=gl

Beta/Release Uplift Approval Request

  • User impact if declined: box model values in inspector don't show under some uncommon scenarios
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's just a work around so we don't hit the platform bug. Just adds z-index to what would be invisible.
  • String changes made/needed:
Attachment #9092759 - Flags: approval-mozilla-beta?
Attachment #9092756 - Flags: approval-mozilla-beta?
Flags: needinfo?(mikokm)
Attachment #9092756 - Attachment is obsolete: true
Attachment #9092756 - Flags: approval-mozilla-beta?

Comment on attachment 9092759 [details]
Bug 1559706 - Workaround for invalid layerization in Inspector r=gl

Works around an RDL bug to avoid missing text in the Inspector. Approved for 70.0b8.

Attachment #9092759 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Reproduced issue with 69.0.1, 70.0b7 using steps from comment 6 on Windows 10, macOS 10.13.
Fix verified with 70.0b8 on Windows 10, macOS 10.13, Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: