text disappears when hovering over box-model values
Categories
(Core :: Web Painting, defect, P2)
Tracking
()
People
(Reporter: alice0775, Assigned: mikokm)
References
(Regression)
Details
(Keywords: nightly-community, regression)
Attachments
(3 files, 2 obsolete files)
6.92 MB,
video/mp4
|
Details | |
28.41 KB,
text/plain
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Steps to reproduce:
- Inspect any element
- Select layout tab
- Mouse hover over box-model values
Actual Results:
The value text disappears
Expected Results:
The value text should be highlighted
Reporter | ||
Comment 1•5 years ago
|
||
Reporter | ||
Comment 2•5 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0ca9a03071b76cb0aca81b83ed451dedd2b7c1f5&tochange=87409f291fa6a003f00ae782528bcd4734eeaee0
Regressed by: 87409f291fa6a003f00ae782528bcd4734eeaee0 Miko Mynttinen — Bug 1413546 - Enable retained display lists for parent process r=mattwoodrow
Miko Mynttinen,
Your patch seems to cause the regression. Can you please look into this?
Reporter | ||
Comment 3•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 4•5 years ago
|
||
Reporter | ||
Comment 5•5 years ago
|
||
Removing xulstore folder in user profile fixes the issue.
It seems to have damaged the profile for some reason.
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 6•5 years ago
|
||
Oops, I can reproduced with new profile...
The following step3-5 seems to depended on window size/fontsize/zoomlevel.
Steps to reproduce:
0. Start Nightly with new profile
- Inspect any element
- Select layout tab
- Undock Inspector i.e. Separate Window
- Maximized the Inspector window
- Zoom in 5 time in the inspector
- Mouse hover over box-model values
Actual Results:
The value text disappears
Expected Results:
The value text should be highlighted
Reporter | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Reproduces on mac too.
Updated•5 years ago
|
Comment 8•5 years ago
|
||
With parent rdl pref force enabled this regressed by https://hg.mozilla.org/integration/autoland/rev/f00a5d27f41760febe43b3ef52b727a54f082abf in my bisection.
Comment 9•5 years ago
|
||
The call to BuildCompositorHitTestInfoIfNeeded changed in that patch is what causes it. Ie passing false for the last argument when the zindex is 0 makes the bug show up.
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 10•5 years ago
|
||
The priority flag is not set for this bug.
:mattwoodrow, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 12•5 years ago
|
||
miko, tnikkel, can one of you take another look at this issue? Maybe we have a chance to fix it for 71.
Assignee | ||
Comment 13•5 years ago
•
|
||
(In reply to Liz Henry (:lizzard) from comment #12)
miko, tnikkel, can one of you take another look at this issue? Maybe we have a chance to fix it for 71.
The root cause for this issue is bug 1534549, which is non-trivial to fix. We could possibly disable the broken hit test info optimization for parent process RDL at the expense of perhaps 10% longer display list builds.
Another possibility might be to implement devtools side workaround by, for example, setting the parent element hit test flags different.
Comment 15•5 years ago
|
||
Patrick, do you think someone on your team might look into a workaround?
Comment 16•5 years ago
|
||
Miko, what do you mean by:
setting the parent element hit test flags different.
Could you explain in details how we might go about doing this in devtools?
Keeping the needinfo on me for now so that, when I know more, I can pass this on to someone to get fixed.
Comment 17•5 years ago
|
||
By the way, I was able to reproduce on macOS with the steps in comment 6.
Updated•5 years ago
|
Assignee | ||
Comment 18•5 years ago
|
||
(In reply to Patrick Brosset <:pbro> from comment #16)
Miko, what do you mean by:
setting the parent element hit test flags different.
Could you explain in details how we might go about doing this in devtools?
Keeping the needinfo on me for now so that, when I know more, I can pass this on to someone to get fixed.
I think I managed to find a workaround. Setting a non-zero z-index for these elements causes them to become stacking contexts, which avoids the gecko bug with layerization.
Assignee | ||
Comment 19•5 years ago
|
||
Assignee | ||
Comment 20•5 years ago
|
||
Comment 21•5 years ago
|
||
Thanks Miko for the reply and for sending a patch! I see it's been accepted, let's land it.
Comment 22•5 years ago
|
||
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3da7c0dce263 Workaround for invalid layerization in Inspector r=gl
Comment 23•5 years ago
|
||
bugherder |
Comment 24•5 years ago
|
||
Please nominate this for Beta approval when you get a chance.
Comment 25•5 years ago
|
||
Comment on attachment 9092759 [details]
Bug 1559706 - Workaround for invalid layerization in Inspector r=gl
Beta/Release Uplift Approval Request
- User impact if declined: box model values in inspector don't show under some uncommon scenarios
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's just a work around so we don't hit the platform bug. Just adds z-index to what would be invisible.
- String changes made/needed:
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 26•5 years ago
|
||
Comment on attachment 9092759 [details]
Bug 1559706 - Workaround for invalid layerization in Inspector r=gl
Works around an RDL bug to avoid missing text in the Inspector. Approved for 70.0b8.
Comment 27•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•5 years ago
|
Comment 28•5 years ago
|
||
Reproduced issue with 69.0.1, 70.0b7 using steps from comment 6 on Windows 10, macOS 10.13.
Fix verified with 70.0b8 on Windows 10, macOS 10.13, Ubuntu 18.04.
Description
•