1559873 - Select Calendar prompt (when accepting an invite or pasting an event) comes up collapsed on TB 68

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

I don't get a popup menu any more, but I can still scroll the calendars with the scroll wheel. However, the prompt when pasting an event doesn't work at all.

Comment 1

[Jorg K (CEST = GMT+2)]

Richard, is this something you could look at?

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Screenshot from 2019-06-18 23-01-36.png

Do you mean this thing?

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: bad-select-calendar.png

Yes, I mean this thing, but mine doesn't work. Before I had a one-line list where I could scroll, now it's completely collapsed.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1559873-choose-calendar-buttons-1.diff

I found a bug, not sure whether it's the one reported, and it isn't in beta.

Edit: it isn't the one reported.

Comment 5

[Jorg K (CEST = GMT+2)]

Hmm, the dialogue can be resized, and then the stuff shows up. But coming up collapsed isn't good, it should have a min-size somewhere.

Comment 6

[Jorg K (CEST = GMT+2)]

(In reply to Geoff Lankow (:darktrojan) from comment #4)

I found a bug, not sure whether it's the one reported, and it isn't in beta.
Edit: it isn't the one reported.

So why are you hijacking my bug?

Min-size is missing somewhere.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1559873-choose-calendar-dialog-2.diff

Yeah, it should. I never liked the default small size of this one.

Comment 8

[Jorg K (CEST = GMT+2)]

(In reply to Geoff Lankow (:darktrojan) from comment #4)

I found a bug, ... , and it isn't in beta.

If it's not in beta, it would be best to split the patch, so only one part goes to beta. Or am I misunderstanding?

Comment 9

[Geoff Lankow (:darktrojan)]

Both parts will work in beta.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a3bca02f2357
Fix accept buttons in calendar chooser dialog, add minimum dimensions. r=philipp

Comment 11

[Jorg K (CEST = GMT+2)]

TB 68 beta 4 / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/de925116b37f44ed76117faa7019cf183825aa8e