Closed Bug 1559873 Opened 1 year ago Closed 1 year ago

Select Calendar prompt (when accepting an invite or pasting an event) comes up collapsed on TB 68

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jorgk-bmo, Assigned: darktrojan)

References

Details

(Keywords: regression)

Attachments

(3 files, 1 obsolete file)

I don't get a popup menu any more, but I can still scroll the calendars with the scroll wheel. However, the prompt when pasting an event doesn't work at all.

Richard, is this something you could look at?

Flags: needinfo?(richard.marti)
Summary: Select Calendar prompt (when accepting an invite) broken on TB 68 → Select Calendar prompt (when accepting an invite or pasting an event) broken on TB 68

Do you mean this thing?

Attached image bad-select-calendar.png

Yes, I mean this thing, but mine doesn't work. Before I had a one-line list where I could scroll, now it's completely collapsed.

I found a bug, not sure whether it's the one reported, and it isn't in beta.

Edit: it isn't the one reported.

Attachment #9072614 - Flags: review?(philipp)
Flags: needinfo?(richard.marti)

Hmm, the dialogue can be resized, and then the stuff shows up. But coming up collapsed isn't good, it should have a min-size somewhere.

(In reply to Geoff Lankow (:darktrojan) from comment #4)

I found a bug, not sure whether it's the one reported, and it isn't in beta.
Edit: it isn't the one reported.

So why are you hijacking my bug?

Min-size is missing somewhere.

Flags: needinfo?(richard.marti)
Summary: Select Calendar prompt (when accepting an invite or pasting an event) broken on TB 68 → Select Calendar prompt (when accepting an invite or pasting an event) comes up collapsed on TB 68

Yeah, it should. I never liked the default small size of this one.

Assignee: nobody → geoff
Attachment #9072614 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #9072614 - Flags: review?(philipp)
Attachment #9072615 - Flags: review?(philipp)
Attachment #9072615 - Flags: approval-calendar-beta?(philipp)
Flags: needinfo?(richard.marti)

(In reply to Geoff Lankow (:darktrojan) from comment #4)

I found a bug, ... , and it isn't in beta.

If it's not in beta, it would be best to split the patch, so only one part goes to beta. Or am I misunderstanding?

Both parts will work in beta.

Attachment #9072615 - Flags: review?(philipp)
Attachment #9072615 - Flags: review+
Attachment #9072615 - Flags: approval-calendar-beta?(philipp)
Attachment #9072615 - Flags: approval-calendar-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a3bca02f2357
Fix accept buttons in calendar chooser dialog, add minimum dimensions. r=philipp

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 7.1
Target Milestone: 7.1 → 7.0
You need to log in before you can comment on or make changes to this bug.