1559972 - oAuth2.0 for Yandex

Status: RESOLVED FIXED

(MailNews Core :: Networking, enhancement)

Description

[kharybin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1.1 Safari/605.1.15

Comment 1

[kharybin]

Add oauth configuration for yandex imap and smtp servers

--- a/mailnews/base/util/OAuth2Providers.jsm
+++ b/mailnews/base/util/OAuth2Providers.jsm
@@ -17,6 +17,9 @@ var kHostnames = new Map([
   ["imap.mail.ru", ["o2.mail.ru", "mail.imap"]],
   ["smtp.mail.ru", ["o2.mail.ru", "mail.imap"]],

+  ["imap.yandex.com", ["oauth.yandex.com", "mail:imap_full"]],
+  ["smtp.yandex.com", ["oauth.yandex.com", "mail:smtp"]],
+
   ["imap.mail.yahoo.com", ["login.yahoo.com", "mail-w"]],
   ["smtp.mail.yahoo.com", ["login.yahoo.com", "mail-w"]],

@@ -44,6 +47,12 @@ var kIssuers = new Map([
     "https://o2.mail.ru/login",
     "https://o2.mail.ru/token",
   ]],
+  ["oauth.yandex.com", [
+    "2a00bba7374047a6ab79666485ffce31",
+    "3ded85b4ec574c2187a55dc49d361280",
+    "https://oauth.yandex.com/authorize",
+    "https://oauth.yandex.com/token",
+  ]],
   ["login.yahoo.com", [
     "dj0yJmk9NUtCTWFMNVpTaVJmJmQ9WVdrOVJ6UjVTa2xJTXpRbWNHbzlNQS0tJnM9Y29uc3VtZXJzZWNyZXQmeD0yYw--",
     "f2de6a30ae123cdbc258c15e0812799010d589cc",

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks, can you please attach the patch for review. I'll take care of it.

Comment 3

[kharybin]

Attachment: patch

Comment 4

[kharybin]

Yes, certainly. I tested it on my Mac. Thank you!

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9073512 [details] [diff] [review]
patch

Very nice, with proper HG header and commit message :-)

Magnus, you reviewed bug 1293958, this looks pretty similar.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9073512 [details] [diff] [review]
patch

Review of attachment 9073512 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=mkmelin

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9073512 [details] [diff] [review]
patch

Let's take this to TB 68 beta and later ESR.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e73c4bbd0df7
Add OAuth2.0 for Yandex. r=mkmelin DONTBUILD

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/25f73f94b5d40c1c2db9e27973500ce595148fbc