Closed Bug 1560145 Opened 4 months ago Closed 4 months ago

background_noise.h compilation is noisy

Categories

(Core :: WebRTC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: kamidphish, Assigned: dminor)

Details

Attachments

(1 file)

There is a typo ChannelParameters::Reset() which causes a warning.

Dan, is this something we have to fix in upstream, or can we fix it locally for now?

Flags: needinfo?(dminor)
Priority: -- → P3

This is the warning I'm seeing:
In file included from /home/dminor/src/firefox2/obj-x86_64-pc-linux-gnu/media/webrtc/trunk/webrtc/modules/audio_coding/neteq_gn/Unified_cpp_neteq_gn1.cpp:29:
0:05.89 In file included from /home/dminor/src/firefox2/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/neteq_impl.cc:22:
0:05.89 /home/dminor/src/firefox2/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/background_noise.h:98:22: warning: possible misuse of comma operator here [-Wcomma]
0:05.89 mute_factor = 0,

This is already fixed upstream so we can go ahead and put a semicolon in ourselves.

Flags: needinfo?(dminor)
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/225a88b05274
Fix typo in modules/audio_coding/neteq/background_noise.h; r=mjf
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.