1560145 - background_noise.h compilation is noisy

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P3)

Description

[u480271]

There is a typo ChannelParameters::Reset() which causes a warning.

Comment 1

[Michael Froman [:mjf]]

Dan, is this something we have to fix in upstream, or can we fix it locally for now?

Comment 2

[Dan Minor [:dminor]]

This is the warning I'm seeing:
In file included from /home/dminor/src/firefox2/obj-x86_64-pc-linux-gnu/media/webrtc/trunk/webrtc/modules/audio_coding/neteq_gn/Unified_cpp_neteq_gn1.cpp:29:
0:05.89 In file included from /home/dminor/src/firefox2/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/neteq_impl.cc:22:
0:05.89 /home/dminor/src/firefox2/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/background_noise.h:98:22: warning: possible misuse of comma operator here [-Wcomma]
0:05.89 mute_factor = 0,

This is already fixed upstream so we can go ahead and put a semicolon in ourselves.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1560145 - Fix typo in modules/audio_coding/neteq/background_noise.h; r=mjf!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/225a88b05274
Fix typo in modules/audio_coding/neteq/background_noise.h; r=mjf

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/225a88b05274