Closed Bug 1560192 Opened 3 years ago Closed 3 years ago

Prompt:Open can be slightly optimized

Categories

(Toolkit :: Notifications and Alerts, defect, P5)

Product:
Toolkit
Component:
Notifications and Alerts
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox67 --- fixed
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: johannh, Assigned: johannh)

Details

Attachments

(1 file)

Bug 1560192 - Clean up prompt open calls in Prompter.jsm. r=Gijs
47 bytes, text/x-phabricator-request
Details | Review

While looking into window modal prompts I noticed that the prompt open code is overly complicated, we can just pass a boolean to that function since we're choosing between two strings anyway.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bfd88bfc61c4
Clean up prompt open calls in Prompter.jsm. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/bfd88bfc61c4

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.