Closed
Bug 1560192
Opened 6 years ago
Closed 6 years ago
Prompt:Open can be slightly optimized
Categories
(Toolkit Graveyard :: Notifications and Alerts, defect, P5)
Toolkit Graveyard
Notifications and Alerts
Tracking
(firefox-esr60 fixed, firefox67 fixed, firefox68 fixed, firefox69 fixed)
RESOLVED
FIXED
mozilla69
People
(Reporter: johannh, Assigned: johannh)
Details
Attachments
(1 file)
While looking into window modal prompts I noticed that the prompt open code is overly complicated, we can just pass a boolean to that function since we're choosing between two strings anyway.
|
Assignee | |
Comment 1•6 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bfd88bfc61c4
Clean up prompt open calls in Prompter.jsm. r=Gijs
|
||
Comment 3•6 years ago
|
||
| bugherder uplift | ||
status-firefox68:
--- → fixed
|
|
||
Comment 4•6 years ago
|
||
| bugherder uplift | ||
status-firefox67:
--- → fixed
|
|
||
Comment 5•6 years ago
|
||
| bugherder uplift | ||
status-firefox-esr60:
--- → fixed
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
|
||
Updated•2 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•