1560205 - Fix WPT background-image-first-line.html to specify a line-height

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Daniel Holbert [:dholbert]]

This WPT test currently fails:
http://w3c-test.org/css/css-backgrounds/background-image-first-line.html
http://w3c-test.org/css/css-backgrounds/reference/background-image-first-line-ref.html

...because the testcase puts the background on a ::first-line selector, and the line-height is left at its default value normal, which for us means ~1.2em which gives the div a height of 120px and the line is offset by 10px.

We should fix the test to avoid this accidental dependency on line-height:normal behavior, by specifying line-height:1 as part of the font declaration in this testcase/reference case.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1560205: Adjust test background-image-first-line.html to specify line-height for Ahem font, for more predictable sizing. r?emilio

This matches the recommendation at:
https://web-platform-tests.org/writing-tests/ahem.html
...and it makes this test start passing. Without this change, the default
line-height:normal behavior effectively behaves like line-height:1.2 in
Firefox, which creates some space between the content and the container's top
border, which makes the test fail.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e3f28ee088c
Adjust test background-image-first-line.html to specify line-height for Ahem font, for more predictable sizing. r=emilio

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1e3f28ee088c

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17469 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged