1560348 - Remove CustomizeMode::_doTransition

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P2)

Description

[Dão Gottwald [:dao]]

This documentation is outdated, e.g. the customize-entered and customize-exiting modes don't exist anymore:

https://searchfox.org/mozilla-central/rev/da14c413ef663eb1ba246799e94a240f81c42488/browser/components/customizableui/CustomizeMode.jsm#484-503

Furthermore, since there's no transition anymore, there seems to be no point in returning a promise, and it might make sense to rename the method. Also, it looks like the customize-entered attribute is redundant with the customizing attribute?

Comment 1

[Dão Gottwald [:dao]]

I expect this was set to P5 because of low / no user impact? This is true for most tasks (as opposed to defects). P5 is borderline wontfix so I don't think we want to generally use this for this kind of task. I would suggest P3.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I was between P3 and P5. Changing to P3 is fine with me.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1560348 - Remove CustomizeMode::_doTransition. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c716cc9f2a70
Remove CustomizeMode::_doTransition. r=Gijs

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset c716cc9f2a70 (bug 1560348) for bc failures at browser_lwt_telemetry.js.
https://hg.mozilla.org/integration/autoland/rev/83a5852130fc37d8a5ccfbd8602a38146244e3b8

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=c716cc9f2a70a92ae6367b6ae13bc9f79faad1fa&selectedJob=283799008

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283799008&repo=autoland&lineNumber=3845

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a0b2626fe8
Remove CustomizeMode::_doTransition. r=Gijs

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e2a0b2626fe8

Comment 8

[Cristina Coroiu [:ccoroiu]]

This was frequently failing, since it has >200 occurrences in the last 24 hours was backed out:
https://hg.mozilla.org/integration/autoland/rev/c31f51b3d5e3f563d324453857b76321a7e8983a

Comment 9

[Andreea Pavel [:apavel]]

Dão, please see https://bugzilla.mozilla.org/show_bug.cgi?id=1369197#c54

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e141ef5f05d2
Remove CustomizeMode::_doTransition. r=Gijs

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e141ef5f05d2