1560494 - list-style-type serializes with symbolic

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Eric Willigers]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

https://jsfiddle.net/ericwilligers/h9pywdqx/

Set list-style-type inline style to 'symbols("string")' or 'symbols(symbolic "string")'
Read specified and computed styles.

Actual results:

'symbols(symbolic "string")'

Expected results:

'symbols("string")' (i.e. shortest serialization)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Something like #[skip_if = "is_symbolic"] is missing in here.

Eric, do you know if there's any WPT for this?

Comment 2

[Eric Willigers]

Proposed WPT
https://github.com/web-platform-tests/wpt/pull/17441

Comment 3

[hgallagher]

Hi, I'll pick this up :-)

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Awesome! Let me know if you have any questions :)

Comment 5

[hgallagher]

Ok I think I have this done but just to be 100% sure about what the output should be before I submit a patch, this is the jsfiddle in my local build now

Property 	        Assigned 	                Serialized 	        Computed
'list-style-type'	'symbols("string")'	        'symbols("string")'	'symbols("string")'
'list-style-type'	'symbols(symbolic "string")'	'symbols("string")'	'symbols("string")'

This is right is it?

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Yeah that looks right to me.

Comment 7

[hgallagher]

Attachment: Bug 1560494 - In CounterStyleOrNone check if SymbolsType is symbolic and skip if it is. r=emilio

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27557022172f
In CounterStyleOrNone check if SymbolsType is symbolic and skip if it is. r=emilio

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/27557022172f