Closed Bug 1560494 Opened 3 months ago Closed 3 months ago

list-style-type serializes with symbolic

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: ericwilligers, Assigned: hgallagher, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=rust])

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

https://jsfiddle.net/ericwilligers/h9pywdqx/

Set list-style-type inline style to 'symbols("string")' or 'symbols(symbolic "string")'
Read specified and computed styles.

Actual results:

'symbols(symbolic "string")'

Expected results:

'symbols("string")' (i.e. shortest serialization)

Component: Untriaged → CSS Parsing and Computation
Product: Firefox → Core

Something like #[skip_if = "is_symbolic"] is missing in here.

Eric, do you know if there's any WPT for this?

Mentor: emilio
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: good-first-bug
Priority: -- → P3
Whiteboard: [lang=rust]

Hi, I'll pick this up :-)

Awesome! Let me know if you have any questions :)

Ok I think I have this done but just to be 100% sure about what the output should be before I submit a patch, this is the jsfiddle in my local build now

Property 	        Assigned 	                Serialized 	        Computed
'list-style-type'	'symbols("string")'	        'symbols("string")'	'symbols("string")'
'list-style-type'	'symbols(symbolic "string")'	'symbols("string")'	'symbols("string")'

This is right is it?

Yeah that looks right to me.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27557022172f
In CounterStyleOrNone check if SymbolsType is symbolic and skip if it is. r=emilio
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → hgallagher
You need to log in before you can comment on or make changes to this bug.