1560530 - Start splitting StaticPrefs.h into multiple files

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement, P2)

Description

[Nicholas Nethercote [inactive]]

StaticPrefs.h is included almost everywhere, and it also changes frequently. As a result, it triggers a lot of recompilation for people.

I plan to split the file into pieces, where all the prefs with the same first segment go in the same file. E.g. all the "gfx.*" prefs would go into StaticPrefs_gfx.h. Most files will only need to import one or two of these smaller headers, which should greatly reduce the amount of recompilation triggered by changes.

Comment 1

[Nicholas Nethercote [inactive]]

Nathan gave me the nice idea of changing StaticPrefs from a class to a namespace. This is relevant because a C++ class must be declared in a single file, but the contents of a namespace can be spread across multiple files. And because class qualification and namespace qualification both use :: in C++, the use points won't need to change.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1561216 - Remove unnecessary `mozilla::` qualifiers in Preferences.cpp. r=froydnj

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1560530 - Split StaticPrefs_accessibility.h from StaticPrefs.h. r=froydnj

This implements the machinery for the splitting of static prefs headers, and
uses it for a single header. #includes are used in such a way that the amount
of boilerplate for each static prefs header file is minimal.

The next patch will split the remaining prefs into more header files.

Comment 4

[Nicholas Nethercote [inactive]]

froydnj: I just landed bug 1562331 so I'm now ready to move forward on this bug. Let me know what you think of the first patch! :)

Comment 5

[Nicholas Nethercote [inactive]]

I was going to do this all in a single bug, but I will now do it across multiple bugs. Bug 1563139 is the tracking bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50cc53e85760
Split StaticPrefs_accessibility.h from StaticPrefs.h. r=froydnj

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/50cc53e85760