Closed
Bug 1560537
Opened 6 years ago
Closed 6 years ago
Use namespace in nsGNOMEShellService
Categories
(SeaMonkey :: OS Integration, task)
Tracking
(seamonkey2.49esr unaffected, seamonkey2.53+ fixed, seamonkey2.57esr+ fixed, seamonkey2.63 unaffected)
RESOLVED
FIXED
seamonkey2.57
| Tracking | Status | |
|---|---|---|
| seamonkey2.49esr | --- | unaffected |
| seamonkey2.53 | + | fixed |
| seamonkey2.57esr | + | fixed |
| seamonkey2.63 | --- | unaffected |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.1)
Attachments
(1 file)
|
2.70 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
When Bug 693469 - Implement mozilla::ArrayLength and mozilla::ArrayEnd, and replace uses of NS_ARRAY_LENGTH whenever possible was ported to SM, using namespace mozilla was not done. This bug fixes that.
Attachment #9073201 -
Flags: review?(frgrahl)
Comment on attachment 9073201 [details] [diff] [review]
Make use of namespace mozilla
Requesting a= for 2.57/2.53
Attachment #9073201 -
Flags: approval-comm-esr60?
Comment on attachment 9073201 [details] [diff] [review]
Make use of namespace mozilla
Low impact change
Attachment #9073201 -
Flags: approval-comm-release?
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9073201 [details] [diff] [review]
Make use of namespace mozilla
I am not sure if I like the new or old source better but this is now how Firefox does it. So lets follow to keep the code as close as possible.
Attachment #9073201 -
Flags: review?(frgrahl)
Attachment #9073201 -
Flags: review+
Attachment #9073201 -
Flags: approval-comm-release?
Attachment #9073201 -
Flags: approval-comm-release+
Attachment #9073201 -
Flags: approval-comm-esr60?
Attachment #9073201 -
Flags: approval-comm-esr60+
|
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9073201 [details] [diff] [review]
Make use of namespace mozilla
Tested and stamped r/a+
|
|
||
Comment 6•6 years ago
|
||
Upps double whammy :)
|
|
||
Comment 7•6 years ago
|
||
Needed for 2.53 and 2.57 only. Was previously fixed in various bugs for comm-central
https://hg.mozilla.org/releases/comm-esr60/rev/1f974ef9418c333cdb5da125745c7313460587dd
status-seamonkey2.53:
--- → affected
status-seamonkey2.57esr:
--- → fixed
status-seamonkey2.63:
--- → unaffected
tracking-seamonkey2.53:
--- → ?
tracking-seamonkey2.57esr:
--- → +
Target Milestone: --- → seamonkey2.57
Version: Trunk → SeaMonkey 2.53 Branch
|
|
||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•5 years ago
|
||
|
||
Updated•10 months ago
|
Version: SeaMonkey 2.53 Branch → SeaMonkey 2.53
You need to log in
before you can comment on or make changes to this bug.
Description
•