1560538 - Open a new tab (about:certificate) to show certificate

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P2)

Description

[Carolina Jimenez Gomez]

I think this is needed, but we should merge with central just at the end of the project, when everything is working...

Comment 1

[Carolina Jimenez Gomez]

Attachment: Bug 1560538 - Opens a new tab to show the certificate. r=johannh

Not sure what to do in pippki.js, for the moment I put an incorrect id.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aa20e0dee5f
Opens a new tab to show the certificate. r=johannh,keeler

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Carolina, is there anything missing here? Andreea landed your patch before you added checkin-needed again but I don't see a second patch or patch modification after that.

Comment 4

[Carolina Jimenez Gomez]

Oh no, sorry, I thought I had to add checkin-needed tag again, since I tried pulling from central and didn't see my changes

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The code initially lands in the autoland repository, every fifth push or every hour (what happens first) all builds and tests run. If there are no issues detected, such a revision can be used to merge the code up to that point to the mozilla-central repository. The goal is to do this every 6 hours on working days if possible. This bug will likely get merged to central in 2-2.5h.

Comment 6

[Carolina Jimenez Gomez]

Thank you for the detailed explanation! I'll be waiting for it then :)

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

If you want to develop based on that, use the autoland tree in a mozilla-unified clone (and rebase it onto central once this bug has been merged to reduce the noise from failures by other pushes).

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7aa20e0dee5f

Comment 9

[Carolina Jimenez Gomez]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b4d666224af4fcac624e0fb437108125f8b07f7

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The new changes are not reviewed. Are the supposed to go into a new bug or at least a new Phabricator ID?

Comment 11

[Carolina Jimenez Gomez]

Hello, I'll ask my mentors to review this again. Thank you

Comment 12

[Johann Hofmann [:johannh]]

You are trying to fix bug 1567161, right? I would suggest creating the patch for review in that bug then.

Closing this bug. :)

Thanks!