Closed Bug 1560538 Opened 6 months ago Closed 5 months ago

Open a new tab (about:certificate) to show certificate

Categories

(Firefox :: Security, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- affected

People

(Reporter: carolina.jimenez.g, Assigned: carolina.jimenez.g, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I think this is needed, but we should merge with central just at the end of the project, when everything is working...

Blocks: 1553524

Not sure what to do in pippki.js, for the moment I put an incorrect id.

Status: NEW → ASSIGNED
Priority: -- → P2
Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7aa20e0dee5f
Opens a new tab to show the certificate. r=johannh,keeler

Keywords: checkin-needed
Keywords: checkin-needed

Carolina, is there anything missing here? Andreea landed your patch before you added checkin-needed again but I don't see a second patch or patch modification after that.

Flags: needinfo?(carolina.jimenez.g)

Oh no, sorry, I thought I had to add checkin-needed tag again, since I tried pulling from central and didn't see my changes

Flags: needinfo?(carolina.jimenez.g)

The code initially lands in the autoland repository, every fifth push or every hour (what happens first) all builds and tests run. If there are no issues detected, such a revision can be used to merge the code up to that point to the mozilla-central repository. The goal is to do this every 6 hours on working days if possible. This bug will likely get merged to central in 2-2.5h.

Thank you for the detailed explanation! I'll be waiting for it then :)

If you want to develop based on that, use the autoland tree in a mozilla-unified clone (and rebase it onto central once this bug has been merged to reduce the noise from failures by other pushes).

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Keywords: checkin-needed
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

The new changes are not reviewed. Are the supposed to go into a new bug or at least a new Phabricator ID?

Keywords: checkin-needed

Hello, I'll ask my mentors to review this again. Thank you

Flags: needinfo?(carolina.jimenez.g)

You are trying to fix bug 1567161, right? I would suggest creating the patch for review in that bug then.

Closing this bug. :)

Thanks!

Status: REOPENED → RESOLVED
Closed: 5 months ago5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.