1560701 - Protection panel header doesn't deal well with long domain names

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Johann Hofmann [:johannh]]

Attachment: Screenshot 2019-06-22 at 05.02.21.png

See screenshot on https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/

I've spent a bunch of time getting this right for the identity panel, so we can probably just copy that.

Comment 1

[Tim Huang[:timhuang] [PTO 10/19 ~ 11/3]]

Attachment: Bug 1560701 - Fixing the issue for the header of the protections panel that it doesn't deal well with long domain names. r?nhnt11!

The patch fixes the problem by setting the correct 'max-width' value for
the header span of the protections panel which was referencing to the
wrong variable.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bce0c13b8071
Fixing the issue for the header of the protections panel that it doesn't deal well with long domain names. r=nhnt11

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/bce0c13b8071

Comment 4

[Negritas Sergiu, Desktop QA]

Following the STR from the description, I reproduced this issue using Fx(2019-05-22) on Windows. I can confirm that this issue is fixed, I verified using Fx 69.0b13 on Ubuntu 18.04 LTS and Windows 10.

Comment 5

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Thank you, Sergiu!