Closed Bug 1560701 Opened 4 months ago Closed 4 months ago

Protection panel header doesn't deal well with long domain names

Categories

(Firefox :: Protections UI, defect, P1)

66 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
firefox69 --- verified

People

(Reporter: johannh, Assigned: timhuang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [privacy-panel])

Attachments

(2 files)

See screenshot on https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/

I've spent a bunch of time getting this right for the identity panel, so we can probably just copy that.

Priority: -- → P1
Whiteboard: [privacy-panel][triage] → [privacy-panel]
Assignee: nobody → tihuang
Status: NEW → ASSIGNED

The patch fixes the problem by setting the correct 'max-width' value for
the header span of the protections panel which was referencing to the
wrong variable.

Attachment #9075633 - Attachment description: Bug 1560701 - Fixing the issue for the header of the protections panel that it doesn't deal well with long domain names. r?johannh! → Bug 1560701 - Fixing the issue for the header of the protections panel that it doesn't deal well with long domain names. r?nhnt11
Attachment #9075633 - Attachment description: Bug 1560701 - Fixing the issue for the header of the protections panel that it doesn't deal well with long domain names. r?nhnt11 → Bug 1560701 - Fixing the issue for the header of the protections panel that it doesn't deal well with long domain names. r?nhnt11!
Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bce0c13b8071
Fixing the issue for the header of the protections panel that it doesn't deal well with long domain names. r=nhnt11
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
QA Whiteboard: [good first verify]

Following the STR from the description, I reproduced this issue using Fx(2019-05-22) on Windows. I can confirm that this issue is fixed, I verified using Fx 69.0b13 on Ubuntu 18.04 LTS and Windows 10.

Thank you, Sergiu!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.