Closed Bug 1560907 Opened 6 months ago Closed 5 months ago

MediaStreamTrack::GetConstraints() returns {mediaSource: "camera"} for all tracks where it should be empty

Categories

(Core :: WebRTC: Audio/Video, defect, P3)

67 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(1 file)

STR:

Create a track that doesn't have constraints: e.g., a received track from a peer connection, a track from a WebAudio MediaStreamAudioDestinationNode, a CanvasCaptureMediaStream track.
Log the result from calling getConstraints() on the track

Expected: {}

Actual: {mediaSource: "camera"}

The model here violates constraints a bit.
Constraints traditionally all constrain on a single pool.
Except we allow default values, which then effectively makes it a switcher between different pools.
Basically this is only used in MediaManager, so we should remove the default, and insert it where it's still needed in MediaManager.

We can do that now if we care terribly, or we can wait for bug 1557174 to rip out mediaSource.

That sounds simple enough, especially given that there's no clear timeline for bug 1557174.

Assignee: nobody → apehrson
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/dc3e09fb750b
Remove default value for mediaSource constraint. r=jib,smaug
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1565317
You need to log in before you can comment on or make changes to this bug.