1560978 - Crash in [@ mozilla::net::HttpChannelParent::WaitForBgParent | mozilla::net::HttpChannelParent::RecvCrossProcessRedirectDone]

Status: RESOLVED WORKSFORME

(Core :: Networking, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-e756fc1d-c9bb-467b-97af-1404a0190624.

Small volume regression which appears to have started in 20190623094201: https://bit.ly/2KzoTm0

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bfee60ff0a54cadfdedd541a8607a56fd1959df2&tochange=48f71175c99922f25dc5311f14db5a72c1b3f726

Top 10 frames of crashing thread:

0 xul.dll class RefPtr<mozilla::MozPromise<bool, nsresult, 0> > mozilla::net::HttpChannelParent::WaitForBgParent netwerk/protocol/http/HttpChannelParent.cpp:688
1 xul.dll class mozilla::ipc::IPCResult mozilla::net::HttpChannelParent::RecvCrossProcessRedirectDone netwerk/protocol/http/HttpChannelParent.cpp:1256
2 xul.dll mozilla::net::PHttpChannelParent::OnMessageReceived ipc/ipdl/PHttpChannelParent.cpp:909
3 xul.dll mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:5576
4 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2082
5 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1970
6 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1225
7 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:486
8 xul.dll void mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:110
9 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308

Comment 1

[Neha Kochar [:neha]]

I smell fission work here.

Comment 2

[Marcia Knous [:marcia]]

Based on the URLs, I think the person who filed Bug 1561205 crashed in this stack.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1560978 - Check if mChannel is null in HttpChannelParent::RecvCrossProcessRedirectDone

The problem seems to be happening when mChannel is null (we crash when calling mChannel->ChannelId() in WaitForBgParent)
It's not clear why it is null at this point, but this check should avoid the crash.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Over to Nhi to assign to someone.

Comment 5

[Marcia Knous [:marcia]]

No crashes since 20190625215814 build in 69 nightly cycle.

Comment 6

[Marcia Knous [:marcia]]

Junior - These crashes stopped happening as of 20190625215814. Do we still have to work on fixing this issue? Thanks.

Comment 7

[Junior [inactive]]

Let's REOPEN if crashes come back. Not landing since we want to know more information if we need to fix something.

Comment 8

[Honza Bambas (:mayhemer)]

Would be good to check the changeset range for 20190625215814 for anything that could fix this. Other option here is that the crash signature simply changed.

Comment 9

[Junior [inactive]]

Thanks for reminding this, Honza.
20190625215814 is the last crash we have.
I check the commits within two days, but I can't get a suspect.

The crash might be caused by fission-dogfooding