add parsing support for text-decoration-skip-ink
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: cmarlow, Assigned: cmarlow)
References
Details
Attachments
(1 file, 1 obsolete file)
Assignee | ||
Comment 1•5 years ago
|
||
This is not ready for full review, I'm uploading it to get some help on adding a new type
There are some clang-format changes that should be fixed by cbrewster's patch
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Updated•5 years ago
|
Comment 5•5 years ago
•
|
||
Triggered Lando (for just part 1 on its own, since the part 0 formatting changes presumably weren't necessary & conflicted with some changes from emilio earlier). But it failed, probably because this needs a rebase after some conflicting changes on autoland.
(see not-too-helpful error message at https://lando.services.mozilla.com/D35831/ )
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21d365e43fec Adding parsing support for text-decoration-skip-ink r=emilio
Comment 7•5 years ago
|
||
Backed out for failing test_bug1112014.html
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=21d365e43fec9db129707c2c4dd8f05d97bd42bc&group_state=expanded&selectedJob=253782224
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253782224&repo=autoland&lineNumber=5542
Backout: https://hg.mozilla.org/integration/autoland/rev/6d6b2dbb430b14391ca12e24e92cf8293461538c
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05f05e197b30 Adding parsing support for text-decoration-skip-ink r=emilio
Comment 9•5 years ago
|
||
bugherder |
Assignee | ||
Comment 10•5 years ago
|
||
When I rebased on central yesterday, the line setting the pref in mochitest.ini was removed. I didn't catch it which is why it failed .test_bug1112014.html. Tests passed after adding it back in.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17707 for changes under testing/web-platform/tests
Upstream PR merged
Comment 13•5 years ago
|
||
I've added a note for this property at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#text-decoration-skip-ink.
Sebastian
Description
•