Closed Bug 1561131 Opened 3 months ago Closed 3 months ago

add parsing support for text-decoration-skip-ink

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: cmarlow, Assigned: cmarlow)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.

This is not ready for full review, I'm uploading it to get some help on adding a new type
There are some clang-format changes that should be fixed by cbrewster's patch

Attachment #9073891 - Attachment description: Bug 1561131: Adding parsing support for text-decoration-skip-ink → Bug 1561131: Adding parsing support for text-decoration-skip-ink r?emilio
Attachment #9073891 - Attachment description: Bug 1561131: Adding parsing support for text-decoration-skip-ink r?emilio → Bug 1561131: Part 1: Adding parsing support for text-decoration-skip-ink r?emilio
Attachment #9073891 - Attachment description: Bug 1561131: Part 1: Adding parsing support for text-decoration-skip-ink r?emilio → Bug 1561131: Adding parsing support for text-decoration-skip-ink r?emilio

Triggered Lando (for just part 1 on its own, since the part 0 formatting changes presumably weren't necessary & conflicted with some changes from emilio earlier). But it failed, probably because this needs a rebase after some conflicting changes on autoland.

(see not-too-helpful error message at https://lando.services.mozilla.com/D35831/ )

Flags: needinfo?(charles.w.marlow)
Attachment #9073891 - Attachment description: Bug 1561131: Adding parsing support for text-decoration-skip-ink r?emilio → Bug 1561131: Part 1: Adding parsing support for text-decoration-skip-ink r?emilio
Attachment #9074320 - Attachment is obsolete: true
Attachment #9073891 - Attachment description: Bug 1561131: Part 1: Adding parsing support for text-decoration-skip-ink r?emilio → Bug 1561131: Adding parsing support for text-decoration-skip-ink r?emilio
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21d365e43fec
Adding parsing support for text-decoration-skip-ink r=emilio
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05f05e197b30
Adding parsing support for text-decoration-skip-ink r=emilio
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

When I rebased on central yesterday, the line setting the pref in mochitest.ini was removed. I didn't catch it which is why it failed .test_bug1112014.html. Tests passed after adding it back in.

Flags: needinfo?(charles.w.marlow)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17707 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.